When compiling dbus 1.6 on cygwin with gcc 3.4.4 the following warning is printed $ cmake /cygdrive/c/kde/trunk/git/dbus-src-git/cmake -- The C compiler identification is GNU 3.4.4 -- The CXX compiler identification is GNU 3.4.4 CMake Warning at /usr/share/cmake-2.8.9/Modules/Platform/CYGWIN.cmake:15 (message): CMake no longer defines WIN32 on Cygwin! (1) If you are just trying to build this project, ignore this warning or quiet it by setting CMAKE_LEGACY_CYGWIN_WIN32=0 in your environment or in the CMake cache. If later configuration or build errors occur then this project may have been written under the assumption that Cygwin is WIN32. In that case, set CMAKE_LEGACY_CYGWIN_WIN32=1 instead. (2) If you are developing this project, add the line set(CMAKE_LEGACY_CYGWIN_WIN32 0) # Remove when CMake >= 2.8.4 is required at the top of your top-level CMakeLists.txt file or set the minimum required version of CMake to 2.8.4 or higher. Then teach your project to build on Cygwin without WIN32. Call Stack (most recent call first): /usr/share/cmake-2.8.9/Modules/CMakeSystemSpecificInformation.cmake:36 (INCLUDE) CMakeLists.txt:1 (project)
Created attachment 73055 [details] [review] Fixed cmake warning
Created attachment 73059 [details] [review] Fixed cmake warning update 1 Previous patch did not fixed the problem complete
Looks good for master, thanks. Please apply. I don't think this is appropriate for dbus-1.6 - it's only a warning, and we shouldn't make cosmetic changes on a stable branch.
applied to master
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.