Bug 5753 - _cairo_svg_document_finish shouldn't dump doc to memory
Summary: _cairo_svg_document_finish shouldn't dump doc to memory
Alias: None
Product: cairo
Classification: Unclassified
Component: svg backend (show other bugs)
Version: 1.1.1
Hardware: x86 (IA32) All
: high normal
Assignee: Emmanuel Pacaud
QA Contact: cairo-bugs mailing list
Keywords: patch
Depends on:
Reported: 2006-01-29 07:18 UTC by Dom Lachowicz
Modified: 2006-03-15 13:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

don't dump the doc to memory before saving (1.66 KB, patch)
2006-01-29 07:18 UTC, Dom Lachowicz
Details | Splinter Review

Description Dom Lachowicz 2006-01-29 07:18:08 UTC
This is somewhat wasteful, and there was a TODO in the code, so I took the
liberty of reimplementing it. Patch to follow.
Comment 1 Dom Lachowicz 2006-01-29 07:18:37 UTC
Created attachment 4499 [details] [review]
don't dump the doc to memory before saving
Comment 2 Emmanuel Pacaud 2006-01-29 07:36:08 UTC
Thanks for your patch.

     xmlFreeDoc (document->xml_doc);
+    xmlFreeNode (document->xml_node_main);

Isn't xmlFreeDoc supposed to free all doc structures, including tree ?
Comment 3 Dom Lachowicz 2006-01-29 07:55:27 UTC
Sorry, that last part slipped in from a new patch that I'm working on.
Comment 4 Emmanuel Pacaud 2006-01-30 04:14:32 UTC
Comment on attachment 4499 [details] [review]
don't dump the doc to memory before saving

Ok to commit.
Comment 5 Dom Lachowicz 2006-01-30 05:11:44 UTC
This patch doesn't play well with bug 5314. Please don't commit.
Comment 6 Emmanuel Pacaud 2006-03-16 08:39:24 UTC
Fixed in master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.