Bug 5678 - Radeon AGP mode setting is broken
Summary: Radeon AGP mode setting is broken
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
Keywords: patch
: 7276 (view as bug list)
Depends on:
Reported: 2006-01-22 01:07 UTC by Tilman Sauerbeck
Modified: 2006-06-19 23:31 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Patch (949 bytes, patch)
2006-01-22 01:08 UTC, Tilman Sauerbeck
no flags Details | Splinter Review
Patch to disable multiple agp mode flags for AGPv3 (781 bytes, patch)
2006-06-07 13:38 UTC, Tilman Sauerbeck
no flags Details | Splinter Review

Description Tilman Sauerbeck 2006-01-22 01:07:10 UTC
Because of missing break statements in a switch block, the Radeon driver doesn't
just one AGP mode flag, but several.
Comment 1 Tilman Sauerbeck 2006-01-22 01:08:11 UTC
Created attachment 4414 [details] [review]
Comment 2 Michel Dänzer 2006-01-22 02:40:42 UTC
As discussed on IRC: The behaviour for AGPv3 may be technically incorrect (but
the kernel seems to deal with it just fine, and there won't be AGP beyond 8x
anyway), but I'm pretty sure the behaviour for AGPv2 is correct and required at
least for older kernels.
Comment 3 Mike A. Harris 2006-03-15 12:07:32 UTC
For the benefit of us who didn't happen to be on IRC at that time, can
someone summarize the conversation here? ;)
Comment 4 Michel Dänzer 2006-03-15 12:12:28 UTC
I don't remember anything significant beyond what's in comment #2, or I would
have added it there.
Comment 5 Benjamin Herrenschmidt 2006-03-15 15:16:27 UTC
I suppose we could fix the AGPx8 case for AGPv3 but it's low priority since the
kernel seems to deal with it fine
Comment 6 Tilman Sauerbeck 2006-06-07 13:38:11 UTC
Created attachment 5842 [details] [review]
Patch to disable multiple agp mode flags for AGPv3

New patch, which only does the change for AGPv3.
Comment 7 Michel Dänzer 2006-06-08 02:24:51 UTC
Looks good.
Comment 8 Alex Deucher 2006-06-08 06:45:01 UTC
looks fine.
Comment 9 Tilman Sauerbeck 2006-06-08 09:51:44 UTC
Mmh, someone commit it then so we can close this bug? :)
Comment 10 Michel Dänzer 2006-06-08 10:29:45 UTC
Fixed in xf86-video-ati HEAD.
Comment 11 Michel Dänzer 2006-06-19 23:31:54 UTC
*** Bug 7276 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.