Bug 5614 - xorg-cf-files ignores configure parameters
Summary: xorg-cf-files ignores configure parameters
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: 7.0.0
Hardware: Other other
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2006-01-16 13:50 UTC by Bernhard Rosenkraenzer
Modified: 2009-10-14 08:31 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Partial patch (this sets just ProjectRoot and MotifDir correctly) (125.80 KB, patch)
2006-01-16 13:53 UTC, Bernhard Rosenkraenzer
no flags Details | Splinter Review

Description Bernhard Rosenkraenzer 2006-01-16 13:50:58 UTC
xorg-cf-files installs a set of default imake .cf files and ignores all 
parameters passed to configure. 
I'd expect 
./configure --prefix=/usr 
to set ProjectRoot to /usr 
./configure --prefix=/usr/X11R7 
to set ProjectRoot to /usr/X11R7 
rather than hardcoding the (obsolete) /usr/X11R6 default. 
Similarily, stuff like Freetype2Dir, ExpatDir, ExpatLibDir, ..... (all defined 
in X11.tmpl) should be set correctly by the configure script rather than 
forcing old defaults on everyone, now that we have a tool that can do better.
Comment 1 Bernhard Rosenkraenzer 2006-01-16 13:53:40 UTC
Created attachment 4361 [details] [review]
Partial patch (this sets just ProjectRoot and MotifDir correctly)

Attaching partial patch; this patch sets only ProjectRoot and MotifDir; the
other settings should be handled the same way
Comment 2 Bernhard Rosenkraenzer 2006-01-16 13:55:54 UTC
There's a bug in the patch I've attached (shouldn't have run configure to test 
after patching ;) ), it should (obviously) remove site.def and X11.tmpl rather 
than patching them to the values I used for testing. 
Comment 3 Daniel Stone 2007-02-27 01:30:00 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 4 Alan Coopersmith 2009-10-14 08:31:55 UTC
The change to set ProjectRoot in site.def(.in) from --prefix was already 
made a while ago by:

commit 3ca574a51927067f958f2eca5f106cf215aee2f5
Author: Matthieu Herrb <matthieu.herrb@laas.fr>
Date:   Sat Apr 15 15:55:25 2006 +0000

    rman is not built by modular tree.
    DefaultRGBDatabase is now in share/X11
    Generate site.def from site.def.in to set ProjectRoot to $prefix
    Remove Bugzilla #6607. ok ajax.

I've just committed another fix to change the default MotifDir from
/usr/X11R6 to ProjectRoot, so it inherits the --prefix setting.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.