Bug 53681 - LibreOffice crashes when trying to browse for a plugin
Summary: LibreOffice crashes when trying to browse for a plugin
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.0.0.0.alpha0+ Master
Hardware: x86-64 (AMD64) All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2012-08-18 17:34 UTC by Stefan Knorr (astron)
Modified: 2012-12-16 11:21 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
bt + console logs on master sources (10.32 KB, text/plain)
2012-08-19 08:47 UTC, Julien Nabet
Details
Log file LOdev 2012-11-22 crashes on Mac OS X 10.6.8, trying to browse for a plug-in (51.19 KB, text/plain)
2012-11-22 14:38 UTC, Roman Eisele
Details
Log file: LOdev 2012-11-22 crashes on Mac OS X 10.6.8, trying to browse for a plug-in (57.77 KB, text/plain)
2012-11-22 14:40 UTC, Roman Eisele
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Knorr (astron) 2012-08-18 17:34:56 UTC
How to reproduce:
1. Open Writer
2. Go to Insert > Object > Plugin...
3. Click "Browse.."

Result: LibreOffice closes unexpectedly.

Version used:
Version 3.7.0.0.alpha0+ (Build ID: 07a33fd), self-built, no Java, Open-SUSE

Doing the same in Open-SUSE's packaged version of 3.5.4 only results in an alert box appearing saying that "the plugin manager is not installed".
Comment 1 Rainer Bielefeld Retired 2012-08-18 17:51:03 UTC
[Reproducible] with parallel installation of Master "LOdev  3.7.0.0.alpha0+   - WIN7 Home Premium (64bit) ENGLISH UI [Build ID: 6900781]" (tinderbox: 2008R2@20, pull time 2012-08-14 09:27:23)	

NOT reproducible with "LibreOffice 3.6.1.1  German UI/Locale [Build-ID:  4db6344] on German WIN7 Home Premium (64bit), so Regression!

Not limited to WRITER, same with CALC / DRAW
Comment 2 Alexander Wilms 2012-08-18 18:02:50 UTC
[Reproducible] with Version 3.6.1.0+ (Build ID: cbb0475)
Ubuntu 12.04 (64 bit) English LibO UI
Comment 3 Julien Nabet 2012-08-19 08:47:27 UTC
Created attachment 65763 [details]
bt + console logs on master sources

On pc Debian x86-64 with master sources updated today, I reproduce the problem.
I attached console logs (just 1 specific trace) + bt with symbols.

I don't reproduce the problem with 3.6 sources updated yesterday but I notice that it's very long before being able to browse.

With 3.5 sources updated yesterday, no crash and the browsing window appears without delay.

Finally, with 3.5 and  3.6, I got this trace 4 times:
** (soffice:14849): WARNING **: Duff filter token ''

(All the tests have been made with Writer)
Comment 4 Alex Thurgood 2012-10-07 08:35:28 UTC
Confirming also on my dev build from master dated 06/10/2012.

Alex
Comment 5 Roman Eisele 2012-11-14 10:12:21 UTC
Already confirmed for Mac OS X, but because I just stumbled over this bug myself I want to add my results, too ;-):

REPRODUCIBLE with LOdev 4.0.0.0.alpha0+ (Build ID: 32315e; pull time: 2012-11-13 00:32:26) on Mac OS X 10.6.8 (Intel).

Would bibisecting help here?! Added “bibisectrequest” tag.
Comment 6 Stephan Bergmann 2012-11-22 11:49:03 UTC
I did some work in this area over the past one or two weeks, and with recent master builds see "Insert - Object - Plug-in... - Browse..." not crash on neither Linux, Mac OS X, nor Windows.  I can't remember though whether I did deliberately fix a crash there.  Can anybody who was able to reproduce the crash please check whether it is still there with recent master builds?
Comment 7 Roman Eisele 2012-11-22 14:38:08 UTC
Created attachment 70434 [details]
Log file LOdev 2012-11-22 crashes on Mac OS X 10.6.8, trying to browse for a plug-in

(In reply to comment #6)
> I did some work in this area over the past one or two weeks, and with recent
> master builds see "Insert - Object - Plug-in... - Browse..." not crash on
> neither Linux, Mac OS X, nor Windows.  I can't remember though whether I did
> deliberately fix a crash there.  Can anybody who was able to reproduce the
> crash please check whether it is still there with recent master builds?

I can still reproduce this crash on Mac OS X 10.6.8 (Intel) with the current master build (LOdev 4.0.0.0.alpha1+, build ID: 1465fd; pull time: 2012-11-22 07:39:42) from
http://dev-builds.libreoffice.org/daily/MacOSX-Intel@27-OSX_10.7.0-gcc_4.2.1_llvm/master/2012-11-22_07.39.42/

by following these steps:
0) Rename/move/delete LOdev user profile folder, to preclude any influence
   of local settings on the test results.
1) Start LOdev.
2) New Writer document.
3) Select "Insert > Object > Plug-in..." from the menu bar
   -> "Insert Plug-in" dialog windo appears.
4) Click on "Browse..." button
   -> Crash. Log file attached.
Comment 8 Roman Eisele 2012-11-22 14:40:58 UTC
Created attachment 70435 [details]
Log file: LOdev 2012-11-22 crashes on Mac OS X 10.6.8, trying to browse for a plug-in



(Sorry, that was the wrong log file; I have too many ;-); this is the right one.)
Comment 9 Stephan Bergmann 2012-11-22 20:43:58 UTC
I tried on Mac OS X now with a master build from yesterday and cannot reproduce.  From looking at your backtrace, it smells like some form of memory corruption when SvInsertPlugInDialog::BrowseHdl calls fillNetscapePluginFilters calls xPMgr->getPluginDescriptions() (which, AFAIU, needs to load the plugin libs to retrieve information from them) shortly before initializing SalAquaFilePicker.  The latter code is generic code to instantiate the file picker, so if it failed in itself it would also fail in other case ("File - Open..." etc.).  It is likely that there are specific plugins that cause trouble here, where you happen to have such a plugin installed while I happen to have not.
Comment 10 Roman Eisele 2012-11-23 08:00:12 UTC
(In reply to comment #9)
> ...] It is likely that there are
> specific plugins that cause trouble here, where you happen to have such a
> plugin installed while I happen to have not.

By “a plugin”, you mean some brower (NPAPI) plugin, not a LibreOffice extension, right? (I have no LibO extensions installed.) I have only a few, quite common NPAPI plugins installed:

* Adobe Acrobat NPAPI Plug-in 10.1.4
* Java-Applet-Plug-In         13.8.3
* QuickTime Plug-In            7.6.6
* Shockwave Flash             11.5.502.110
* iPhotoPhotocast              7.0           [decativated]

Which ones of these Plug-Ins do you NOT have? If I know this, I can try do deactivate them and then test if LOdev still crashes ...
Comment 11 Stephan Bergmann 2012-11-23 08:34:27 UTC
(In reply to comment #10)
> By “a plugin”, you mean some brower (NPAPI) plugin, not a LibreOffice
> extension, right? (I have no LibO extensions installed.) I have only a few,
> quite common NPAPI plugins installed:
> 
> * Adobe Acrobat NPAPI Plug-in 10.1.4
> * Java-Applet-Plug-In         13.8.3
> * QuickTime Plug-In            7.6.6
> * Shockwave Flash             11.5.502.110
> * iPhotoPhotocast              7.0           [decativated]
> 
> Which ones of these Plug-Ins do you NOT have? If I know this, I can try do
> deactivate them and then test if LOdev still crashes ...

I only have Safari and Adobe Flash Player (allowing to display flash content in Safari) installed on that machine, no Firefox.  And I don't know any way to get a list of plugins available in a Safari installation (similar to "about:plugins" in Firefox).
Comment 12 Caolán McNamara 2012-11-23 10:47:12 UTC
Where can "Adobe Acrobat NPAPI Plug-in 10.1.4" for macosx firefox be found these days ? It appears blacklisted on addons.mozilla.org (which I guess may make it a potential candidate for triggering the macosx crash)
Comment 13 Julien Nabet 2012-11-23 20:34:42 UTC
Just for information, on pc Debian x86-64 with master sources updated today (commit 8f703e108acad813188f1698ab5be31981da017d) with "make clean" before building + brand new LO profile, I don't reproduce the crash anymore
Comment 14 Roman Eisele 2012-11-24 09:44:58 UTC
(In reply to comment #12)
> Where can "Adobe Acrobat NPAPI Plug-in 10.1.4" for macosx firefox be found
> these days ? It appears blacklisted on addons.mozilla.org (which I guess may
> make it a potential candidate for triggering the macosx crash)

Ah -- a very good hint, thank you! I will try to deactivate it ...

About “where can ... be found?” Well, it can not be found for download anymore, but it is still installed on my machine; Firefox 17.0 does not complain about it and does not deactivate it; so mozilla’s blacklisting seems to be a bit inconsequent ;-)
Comment 15 Roman Eisele 2012-11-24 10:30:15 UTC
... and the hint was right (thank you, Caolán!):

After killing the old “Adobe Acrobat NPAPI Plug-in” 10.1.4, browsing for a plug-in does work both in LibreOffice 3.6.4.1 and in LOdev 4.0.0.0.alpha1+ (build ID: 1465fd; pull time: 2012-11-22 07:39:42).

It still works after installing Adobe Reader XI (11.0), which brings version 11.0 of the “AdobePDFViewerNPAPI.plugin”: the crash does not return, browsing for a plug-in and even selecting either the “Flash Player.plugin” or the new “AdobePDFViewerNPAPI.plugin” works.


@ Stephan Bergmann et all.:
So I am sorry for the wrong alarm! Browsing for a plug-in really works now on Mac OS X (10.6.8 Intel), obviously it was the “Adobe Acrobat NPAPI Plug-in” 10.1.4 which caused or triggered the crashes.

Thank you all for your hints ...


A little countergift (“Gegengabe”) from me:
(In reply to comment #11)
> [...] And I don't know any way to get a list of plugins available in
> a Safari installation (similar to "about:plugins" in Firefox).

There is such a way, but well hidden: In Safari (at least in version 5.1.7), you get a list of all installed plug-ins via “Help > Installed Plug-Ins...”.
Comment 16 Roman Eisele 2012-11-24 10:34:45 UTC
@ Rainer Bielefeld,
@ Fabian Alexander Wilms,
@ Julien Nabet,
@ Alex Thurgood:

You have reproduced this issue with older master builds. Can you please check if the crash is fixed for you, too -- then we can close this bug report --, or if you still can reproduce it? (And *if* you still can reproduce it, could you please check, like I did, if some particular NPAPI plug-in causes the crash?)

Thank you very much!
Comment 17 Julien Nabet 2012-11-24 10:55:44 UTC
(In reply to comment #16)
> @ Rainer Bielefeld,
> @ Fabian Alexander Wilms,
> @ Julien Nabet,
> @ Alex Thurgood:
> 
> You have reproduced this issue with older master builds. Can you please
> check if the crash is fixed for you, too -- then we can close this bug
> report --, or if you still can reproduce it? (And *if* you still can
> reproduce it, could you please check, like I did, if some particular NPAPI
> plug-in causes the crash?)
> 
> Thank you very much!

Roman: Ok for me (see https://bugs.freedesktop.org/show_bug.cgi?id=53681#c13 :-))
Comment 18 Stefan Knorr (astron) 2012-11-25 00:41:31 UTC
Can't reproduce any more either (with new build and deleted ~/.config/libroffice dir).

=> setting to WORKSFORME.