Bug 53171 - examples: fix boolean option parsing
Summary: examples: fix boolean option parsing
Status: RESOLVED FIXED
Alias: None
Product: Ytstenut
Classification: Unclassified
Component: ytstenut-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: ytstenut
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-08-06 16:41 UTC by Simon McVittie
Modified: 2012-08-06 18:38 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
examples: fix boolean option parsing (3.93 KB, patch)
2012-08-06 16:41 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2012-08-06 16:41:49 UTC
Created attachment 65187 [details] [review]
examples: fix boolean option parsing

Under gcc, sizeof(bool) is 1, while sizeof(gboolean) is 4 (on every
platform we care about). This means that passing a bool * to a GLib
function expecting a gboolean * leads to an overflow of 3 bytes.
Comment 1 Olli Salli 2012-08-06 17:56:08 UTC
++
Comment 2 Simon McVittie 2012-08-06 18:38:55 UTC
Thanks, merged


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.