Bug 51250 - tp_debug_client_get_messages_async: error is not propagated
Summary: tp_debug_client_get_messages_async: error is not propagated
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: r+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-06-20 02:07 UTC by Guillaume Desmottes
Modified: 2012-06-20 04:07 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
debug-client: propagate error if GetMessages() failed (1.84 KB, patch)
2012-06-20 02:08 UTC, Guillaume Desmottes
Details | Splinter Review

Description Guillaume Desmottes 2012-06-20 02:07:07 UTC
It should be.
Comment 1 Guillaume Desmottes 2012-06-20 02:08:19 UTC
Created attachment 63252 [details] [review]
debug-client: propagate error if GetMessages() failed
Comment 2 Simon McVittie 2012-06-20 03:39:42 UTC
++

For future reference, whenever you're waiting for a single event to happen, you can use tp_tests_result_ready_cb as the callback and tp_tests_run_until_result to wait for it, then "_finish" afterwards - this makes the test more linear, with less happening in callbacks. See tests/dbus/account-request.c, for instance.
Comment 3 Guillaume Desmottes 2012-06-20 04:07:46 UTC
Merged to master for 0.19.2


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.