Bug 48771 - tp_capabilities_supports_ does not check for unknown fixed properties
Summary: tp_capabilities_supports_ does not check for unknown fixed properties
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/xc...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-04-16 07:41 UTC by Xavier Claessens
Modified: 2012-04-17 04:07 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Xavier Claessens 2012-04-16 07:41:16 UTC 
They should return TRUE only if all fixed properties are known
Comment 1 Xavier Claessens 2012-04-16 07:42:07 UTC 
Fix:
http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=caps

Some unit tests may help I guess.
Comment 2 Xavier Claessens 2012-04-16 13:14:41 UTC 
The branch now has unit test for call
Comment 3 Simon McVittie 2012-04-17 03:00:55 UTC 
(In reply to comment #2)
> The branch now has unit test for call

... but not for tubes or RoomList.

Does the RoomList implementation work with all known RoomList CMs?

(It doesn't allow TargetHandleType to be disallowed - the spec says THT should always be fixed, possibly to NONE, except that ContactSearch has it disallowed because we got it wrong in the first couple of implementations. If every CM has THT=NONE in Fixed for RoomList then your implementation is OK.)
Comment 4 Xavier Claessens 2012-04-17 04:07:58 UTC 
fixed and merged, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.