Bug 48471 - TpConnection self_contact / TpContact circular reference results in a leak
Summary: TpConnection self_contact / TpContact circular reference results in a leak
Status: RESOLVED DUPLICATE of bug 63027
Alias: None
Product: Telepathy
Classification: Unclassified
Component: libtelepathy (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Vivek Dasmohapatra
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/vi...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-04-09 10:11 UTC by Vivek Dasmohapatra
Modified: 2013-05-01 16:25 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Vivek Dasmohapatra 2012-04-09 10:11:31 UTC 
TpContacts ref their parent TpConnection, the TpConnection
refs its self contact - the resulting circular ref results
in TpConnections never being freed.
Comment 1 Simon McVittie 2012-04-10 02:00:55 UTC 
> The reffed TpContact in the self_contact member should be unreffed on dispose

Fine.

> TpContact is [potentially] reffed by TpConnection: can't hold a TpConnection ref

I think this is an API break: functionality that used to work (getting a contact's connection) no longer does.

We should certainly fix it on next (by breaking the circular ref in one direction or the other - probably the direction you've implemented here), but I don't think this is acceptable in a branch that isn't breaking API.
Comment 2 Vivek Dasmohapatra 2012-04-10 04:48:05 UTC 
> I think this is an API break: functionality that used to work (getting a
> contact's connection) no longer does.

Ok. Any particular keyword/whiteboard-fu I should use to indicate that?
Comment 3 Will Thompson 2013-05-01 16:25:39 UTC 
Fixed in 0.21.0.

*** This bug has been marked as a duplicate of bug 63027 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.