Bug 47940 - Fix dependency toolchain for glib in Android
Summary: Fix dependency toolchain for glib in Android
Status: RESOLVED FIXED
Alias: None
Product: Ytstenut
Classification: Unclassified
Component: ytstenut-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: ytstenut
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-03-27 05:14 UTC by Alvaro Soliverez
Modified: 2012-08-06 16:35 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Add pkg-config --static to Android build (983 bytes, patch)
2012-03-27 05:14 UTC, Alvaro Soliverez
Details | Splinter Review

Description Alvaro Soliverez 2012-03-27 05:14:26 UTC
Created attachment 59109 [details] [review]
Add pkg-config --static to Android build

On Android, use pkg-config --static
    
    This makes it output the complete dependency chain for each
    library, e.g. libffi for GObject. This is necessary because Android
    toolchains don't follow shared library interdependencies like
    normal GNU toolchains.
Comment 1 Robert Staudinger 2012-03-28 00:23:35 UTC
According to pkg-config --help:

    --static        output linker flags for static linking

Is this what we are moving to, for the Android build? That's quite different from what the commit message says.
Comment 2 Alvaro Soliverez 2012-03-28 03:50:07 UTC
The result of that flag is that pkg-config will output the whole dependency chain.

In the case at hand, without that flag, pkg-config will only output the flags for glib. With the flag, it will also output the flags for libffi, which is a new glib dependency.

It's either that, or add the libffi flags in configure.ac, and all the relevant Makefile.am files
Comment 3 Simon McVittie 2012-08-06 16:35:39 UTC
(In reply to comment #2)
> The result of that flag is that pkg-config will output the whole dependency
> chain.

Android does need this, so, applied.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.