Bug 4711 - [PATCH] Xft symbol reduction
Summary: [PATCH] Xft symbol reduction
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xft (show other bugs)
Version: git
Hardware: All All
: medium minor
Assignee: Xorg Project Team
QA Contact:
Keywords: patch
Depends on: 3360
  Show dependency treegraph
Reported: 2005-10-07 18:25 UTC by Alan Coopersmith
Modified: 2006-06-03 03:41 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Patch against Xorg CVS head (21.80 KB, patch)
2005-10-07 18:26 UTC, Alan Coopersmith
no flags Details | Splinter Review

Description Alan Coopersmith 2005-10-07 18:25:53 UTC
Xft has a lot of private symbols left exported to the world - marking these to be
hidden at link time can reduce linker overhead.  Patch will follow momentarily to
mark functions defined in xftint.h with _X_HIDDEN and Xft.h as _X_EXPORT.
Comment 1 Alan Coopersmith 2005-10-07 18:26:59 UTC
Created attachment 3512 [details] [review]
Patch against Xorg CVS head

Should probably be reviewed by KeithP before committing to CVS to verify none
the symbols I've marked _X_HIDDEN need to be visible outside libXft.so.
Comment 2 Daniel Stone 2006-03-05 21:14:41 UTC
keith, comments? i guess it would need to be updated to the new world order, though.
Comment 3 Keith Packard 2006-03-06 03:29:45 UTC
Looks like a reasonable change to me. One question is whether xlibs CVS for Xft
has been moved to xorg/lib yet or not; right now the canonical version of at
least some of the 'xlibs' libraries remains over there. I'd prefer to avoid the
same disaster as the x server migration had.
Comment 4 Daniel Stone 2006-03-06 03:45:55 UTC
which disaster?  i packaged for quite a while under the assumption that your
statement that xft/xcursor/xrender mainline would move to xorg/lib when r7 was
released, which it is ... some clarity would probably be welcome.
Comment 5 Keith Packard 2006-03-06 06:51:37 UTC
the X.org CVS was built by importing from XFree86, and then the kdrive bits were
grafted in place. The result is a CVS history which is muddied beyond the
ability of cvsps to comprehend, which means migrating from CVS to any other SCM
is somewhat challenging.

What I'd like to see for these libraries is that the existing X.org history be
nuked and a single patch applied to the xlibs bits to bring them in line with
X.org release processes. I've done that with compositeproto, fixesproto and
damageproto and have migrated those to git. Would it be reasonable to publish
these .git repositories?
Comment 6 Erik Andren 2006-04-18 05:11:58 UTC
Added patch keyword
Comment 7 Daniel Stone 2006-06-03 03:41:24 UTC
committed, 2.1.9 released

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.