Created attachment 57495 [details] [review] Fixed gabble linking These 2 patches fix linking after the changes in Gabble and Salut
Created attachment 57496 [details] [review] Fixed salut linking
Why do you mention the library name explicitly in the first place? If we look at the pkgconfig files for Gabble and Salut: Gabble: > Libs: -L${libdir} -lgabble-plugins Salut: > Libs: -L${libdir} -lsalut-plugins So you're currently passing for Gabble -L/some/where -lgabble-plugins -lgabble-plugins and for Salut -L/some/where -lsalut-plugins -ltelepathy-salut. Salut with the new plugin API however builds a lib called libgabble-plugins.so, which you're supposed to link against. And even for gabble, mentioning the lib explicitly is redundant; it defeats the point of using pkg-config - if you just used the pkg-config provided library values, none of these changes would be needed in the first place. So no candy from me.
Created attachment 57527 [details] [review] Fixed gabble linking Removed hard linking from gabble as it is no longer needed
(In reply to comment #2) > Why do you mention the library name explicitly in the first place? If we look > at the pkgconfig files for Gabble and Salut: > > Gabble: > > Libs: -L${libdir} -lgabble-plugins > > Salut: > > Libs: -L${libdir} -lsalut-plugins > > So you're currently passing for Gabble -L/some/where -lgabble-plugins > -lgabble-plugins and for Salut -L/some/where -lsalut-plugins -ltelepathy-salut. > > Salut with the new plugin API however builds a lib called libgabble-plugins.so, > which you're supposed to link against. > > And even for gabble, mentioning the lib explicitly is redundant; it defeats the > point of using pkg-config - if you just used the pkg-config provided library > values, none of these changes would be needed in the first place. > > So no candy from me. I removed the Gabble hardlinking, but the salut one has to stay, for now. It's looking for stuff present in telepathy-salut lib, not in salut-plugins.
OK for now. We have to sort the Salut issue better in the future though...
commit 90b96db4e39656a912be0e0bec1b6c90dda750e3 Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk> Date: Thu Feb 23 12:30:48 2012 -0300 Fixed linking after salut plugin library refactor commit e28b2ced285b015fbee2ea80c9b9f9155494e331 Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk> Date: Mon Feb 27 11:06:46 2012 -0300 Fixed linking after gabble plugin library refactor
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.