Bug 46273 - Allow multiple instances of single application on system bus
Summary: Allow multiple instances of single application on system bus
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Alban Crequy
QA Contact: John (J5) Palmieri
URL: http://cgit.collabora.com/git/user/al...
Whiteboard: review+ smcv
Keywords: patch
: 46886 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-19 00:21 UTC by Jiri Pirko
Modified: 2012-03-29 04:25 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Jiri Pirko 2012-02-19 00:21:04 UTC
Imagine application which has to be on system bus and has to have multiple instances. These instances have service names foo.bar.dev1, foo.bar.dev2...

Now you need to put this into policy file. Something like: <allow own="foo.bar.*"/>. This is not possible at the moment though. Only "*" is possible to allow everything. Please implement this extended wildcard checking.
Comment 1 Simon McVittie 2012-03-12 07:34:34 UTC
*** Bug 46886 has been marked as a duplicate of this bug. ***
Comment 2 Simon McVittie 2012-03-12 07:38:06 UTC
(In reply to comment #0)
> Now you need to put this into policy file. Something like: <allow
> own="foo.bar.*"/>. This is not possible at the moment though.

Instead of extending the subset of wildcards we support, I think I'd prefer <allow own_prefix="foo.bar"/>, which seems like it covers the only sensible use-case for this.

There are patches on duplicate Bug #46886. The implementation looks OK but documentation and regression tests are missing. Alban, could you add those, and I'll review?
Comment 3 Jiri Pirko 2012-03-12 07:55:01 UTC
(In reply to comment #2)
> (In reply to comment #0)
> > Now you need to put this into policy file. Something like: <allow
> > own="foo.bar.*"/>. This is not possible at the moment though.
> 
> Instead of extending the subset of wildcards we support, I think I'd prefer
> <allow own_prefix="foo.bar"/>, which seems like it covers the only sensible
> use-case for this.
> 
> There are patches on duplicate Bug #46886. The implementation looks OK but
> documentation and regression tests are missing. Alban, could you add those, and
> I'll review?

Proposed patch looks good to me.
Comment 4 Alban Crequy 2012-03-22 04:58:54 UTC
Branch "own_prefix2" updated after review from Bug #46886 Comment #2-3.
Comment 5 Simon McVittie 2012-03-23 12:30:10 UTC
(In reply to comment #4)
> Branch "own_prefix2" updated after review from Bug #46886 Comment #2-3.

Nice, I hadn't thought of doing the tests like that. I'll merge this next week if none of the reviewer cabal object to it, but for now, r+ from me.
Comment 6 Simon McVittie 2012-03-29 04:25:49 UTC
This went into 1.5.12.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.