current master doesn't cross compile with mingw32 SDK
patch with build fixes
Patch looks ok. Use keywords field instead of whiteboard for "patch" please, bugzilla has a special meaning for that field.
Patch looks good, so this is only about nit picking. +#Check operating system There's no need for that comment, the code makes it pretty clear. +AC_MSG_CHECKING([operating system]) Please use AC_MSG_CHECKING([for operating system]) +case "$host" in + *-*-*mingw*|*-*-*cygwin*) + platform=win32 + AC_MSG_RESULT($platform) + ;; + *) + platform=linux/other Let's call that platform "generic" please. + AC_MSG_RESULT($platform) + ;; +esac Let's just have one AC_MSG_RESULT after the switch please. +AM_CONDITIONAL([WINDOWS], [test "$platform" = "win32"] Please call that conditional PLATFORM_WINDOWS or OS_WINDOWS. +if test "$platform" = "win32" +then Please stick to the formatting: "if foo; then" on a single line Thanks
patch updated, and re tested on linux and windows. Patch is not rebased since fdo is down :(. if it conflicts really badly please reassign it to me, I'll be happy to resolve the conflicts.
Thanks kindly commit 2916018392df240d98fe00dc9e1c08b2547aeb5f Author: Siraj Razick <siraj.razick@collabora.co.uk> Date: Tue Jan 3 20:59:36 2012 -0500 Build fixes for Mingw32 These changes enables us to cross-compile ytstenut-glib for windows with mingw32.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.