Bug 4406 - DRI isn't really that broken
Summary: DRI isn't really that broken
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Ext/DRI (show other bugs)
Version: git
Hardware: PowerPC Mac OS X (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-09 10:32 UTC by Adam Jackson
Modified: 2007-01-23 20:00 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
dri-not-really-broken-1.patch (2.33 KB, patch)
2005-09-09 10:38 UTC, Adam Jackson 		no flags Details | Splinter Review
View All

Description Adam Jackson 2005-09-09 10:32:29 UTC 
there's an ugly hack in GL/dri/dri.c to take the drawable lock on every
ValidateTree.  really we only need to do that when we're updating DRI drawables
specifically, but simply undefining DRI_BROKEN doesn't work because the logic is
wrong.
Comment 1 Adam Jackson 2005-09-09 10:38:33 UTC 
Created attachment 3212 [details] [review]
dri-not-really-broken-1.patch

move the drawable lock acquisition into ClipNotify and only run it when
touching a DRI window.	mark drawable lock acquisition on a per-screen basis
(instead of once globally, which is wrong) and release it in the BlockHandler
if necessary.
Comment 2 Adam Jackson 2006-01-07 05:02:04 UTC 
applied to head, closing

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.