Bug 44056 - telepathy-gabble-xmpp-console mix GIR and pygtk
Summary: telepathy-gabble-xmpp-console mix GIR and pygtk
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium minor
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-12-22 06:45 UTC by Laurent Bigonville
Modified: 2012-01-05 02:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
telepathy-gabble-xmpp-console: no need to import pygtk (861 bytes, patch)
2011-12-22 07:03 UTC, Guillaume Desmottes
Details | Splinter Review

Description Laurent Bigonville 2011-12-22 06:45:15 UTC
Hi,

telepathy-gabble-xmpp-console is calling this:

import pygtk
pygtk.require('2.0')

and then use introspection binding.

I think this are not needed anymore and can be dropped
Comment 1 Guillaume Desmottes 2011-12-22 07:03:24 UTC
Created attachment 54701 [details] [review]
telepathy-gabble-xmpp-console: no need to import pygtk

In gobject-introspection we trust.
Comment 2 Jonny Lamb 2011-12-22 08:44:35 UTC
gogogogogogogogo
Comment 3 Guillaume Desmottes 2012-01-05 02:13:21 UTC
Merged to master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.