telepathy-glib fails to cross compile with mingw32.
patch with build fixes
+#ifdef G_OS_WIN32 + case TP_SOCKET_ADDRESS_TYPE_UNIX: + case TP_SOCKET_ADDRESS_TYPE_ABSTRACT_UNIX: + break; +#endif Shouldn't this section be an #else of the previous clause? Or at least be "#ifndef HAVE_GIO_UNIX"
What Stef said. The rest looks fine, or can those includes be removed completely?
(In reply to comment #3) > What Stef said. The rest looks fine, or can those includes be removed > completely? Yep, I removed the headers and it compiles fine on linux and also in mingw.. the patch is now updated with all the changes proposed.
(In reply to comment #4) > (In reply to comment #3) > > What Stef said. The rest looks fine, or can those includes be removed > > completely? > > Yep, I removed the headers and it compiles fine on linux and also in mingw.. > the patch is now updated with all the changes proposed. Looks good. Do you have permissions to push or shall I do it for you?
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > What Stef said. The rest looks fine, or can those includes be removed > > > completely? > > > > Yep, I removed the headers and it compiles fine on linux and also in mingw.. > > the patch is now updated with all the changes proposed. > > Looks good. > > Do you have permissions to push or shall I do it for you? Hi, nop.. I don't have permission, it would be cool if you can push it :)
Merged, thanks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.