Bug 42954 - Call: Why does MediaDescription.Reject return a reason?
Summary: Call: Why does MediaDescription.Reject return a reason?
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
Whiteboard: Call
Keywords: patch
Depends on:
Reported: 2011-11-15 10:32 UTC by Olivier Crête
Modified: 2011-12-23 01:08 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

patch to just remove the reason on Reject (1.05 KB, patch)
2011-12-14 13:26 UTC, Olivier Crête
Details | Splinter Review

Description Olivier Crête 2011-11-15 10:32:52 UTC
That bit just doesn't make sense to me.. My guess is that it was supposed to be an "in" parameter. But even then, the reason is always the same, "we don't support these codecs".


I propose just reverting patch 3f962ace757d8d323effd5d316c5d5c391c6a698 .. and removing the FIXME.
Comment 1 Olivier Crête 2011-12-13 13:15:22 UTC
It also doesn't make sense as a in parameter.. There is a single reason to reject codecs.. they're not compatible.
Comment 2 Olivier Crête 2011-12-14 13:26:22 UTC
Created attachment 54438 [details] [review]
patch to just remove the reason on Reject

There is no point in having an argument, I don't see another reason..
Comment 3 Xavier Claessens 2011-12-16 04:25:09 UTC
Can't you also reject a MD for example because you don't like the codec? like if it propose animated jpeg and you want to reject even if you could use it? dunno, just wondering...

I would just like avoid having later a RejectWithReason() extra call just because we didn't though about a case... But if you're 100% sure it is useless, I'm ok :)
Comment 4 Olivier Crête 2011-12-16 07:30:09 UTC
Good point, lets keep it then

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.