That bit just doesn't make sense to me.. My guess is that it was supposed to be an "in" parameter. But even then, the reason is always the same, "we don't support these codecs".
I propose just reverting patch 3f962ace757d8d323effd5d316c5d5c391c6a698 .. and removing the FIXME.
It also doesn't make sense as a in parameter.. There is a single reason to reject codecs.. they're not compatible.
Created attachment 54438 [details] [review]
patch to just remove the reason on Reject
There is no point in having an argument, I don't see another reason..
Can't you also reject a MD for example because you don't like the codec? like if it propose animated jpeg and you want to reject even if you could use it? dunno, just wondering...
I would just like avoid having later a RejectWithReason() extra call just because we didn't though about a case... But if you're 100% sure it is useless, I'm ok :)
Good point, lets keep it then