Bug 42532 - Support for building on Android
Summary: Support for building on Android
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Rob Taylor
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-11-02 13:18 UTC by Alvaro Soliverez
Modified: 2011-11-03 08:18 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to build on Android (2.45 KB, patch)
2011-11-02 13:18 UTC, Alvaro Soliverez
Details | Splinter Review

Description Alvaro Soliverez 2011-11-02 13:18:57 UTC
Created attachment 53082 [details] [review]
Patch to build on Android

This patch enables building dbus-glib on Android using Android NDK and androgenizer
Comment 1 Simon McVittie 2011-11-03 05:00:27 UTC
Comment on attachment 53082 [details] [review]
Patch to build on Android

Review of attachment 53082 [details] [review]:
-----------------------------------------------------------------

Mostly looks fine, one query:

::: Android.mk
@@ +15,5 @@
> +	CPP=$(CONFIGURE_CPP) \
> +	CPPFLAGS="$(CONFIGURE_CPPFLAGS)" \
> +	PKG_CONFIG_LIBDIR="$(CONFIGURE_PKG_CONFIG_LIBDIR)" \
> +	PKG_CONFIG_TOP_BUILD_DIR=$(PKG_CONFIG_TOP_BUILD_DIR) \
> +	ac_cv_have_abstract_sockets=no \

Does Android really not have abstract sockets? They're a Linux kernel feature (originally from Solaris or something, I think), so even though Android doesn't have GNU userland, I'd expect abstract sockets to work.

(Abstract sockets are Unix sockets where the first byte of the address is \0 and all subsequent bytes are significant.)
Comment 2 Simon McVittie 2011-11-03 05:15:13 UTC
(In reply to comment #1)
> > +	ac_cv_have_abstract_sockets=no \
> 
> Does Android really not have abstract sockets? They're a Linux kernel feature
> (originally from Solaris or something, I think), so even though Android doesn't
> have GNU userland, I'd expect abstract sockets to work.

Actually, never mind: this is dbus-glib, not dbus, so the abstract sockets check is completely pointless (the equivalent check in dbus is the one that matters). My branch in Bug #40711 discards it altogether; I'd appreciate review on that bug (preferably from a dbus reviewer, but anyone who knows Autotools really).

Fixed in git for 0.100.
Comment 3 Thiago Macieira 2011-11-03 08:18:21 UTC
(In reply to comment #2)
> Actually, never mind: this is dbus-glib, not dbus, so the abstract sockets
> check is completely pointless (the equivalent check in dbus is the one that
> matters). My branch in Bug #40711 discards it altogether; I'd appreciate review
> on that bug (preferably from a dbus reviewer, but anyone who knows Autotools
> really).

You know, even the one in dbus-1 is rather pointless because it tests the host system, not the target. The test should be done at runtime by trying to create an abstract socket and falling back to a regular one.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.