Bug 4249 - [PATCH] minclock guess probably too low
Summary: [PATCH] minclock guess probably too low
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/mga (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Ian Romanick
QA Contact: Xorg Project Team
URL: http://bugs.debian.org/cgi-bin/bugrep...
Whiteboard:
Keywords: patch
: 2601 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-08-26 00:05 UTC by Daniel Stone
Modified: 2007-07-30 03:41 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
increase minclock to 17750 (996 bytes, patch)
2005-08-26 00:06 UTC, Daniel Stone
no flags Details | Splinter Review

Description Daniel Stone 2005-08-26 00:05:40 UTC
Patch attached -- basically, a G550 user has reported that dotclocks needed to
be at least 17750Hz to not lock up his card.  Either we need to increase the
minimum dotclock for everyone, or just for >= G550, at a guess.  Debian patch #099m.
Comment 1 Daniel Stone 2005-08-26 00:06:24 UTC
Created attachment 3042 [details] [review]
increase minclock to 17750
Comment 2 Adam Jackson 2005-08-26 09:21:02 UTC
12 to 18 MHz is not a lot of difference, you'd break 512x384@60 and below but oh
well.

this gets my vote.
Comment 3 Ian Romanick 2005-10-19 17:39:21 UTC
I may be misunderstanding something, but should the value of MinClock be derived
from pMga->bios.pixel.min_freq?  For all cards before the G450 the default value
is 50MHz.  For the G450 it jumps to 256MHz.
Comment 4 Daniel Stone 2005-10-19 17:43:47 UTC
if it's reliable, it seems a sensible thing to do.  i can have a go at getting
back to the user if you're more comfortable with that, but this seems like a
good interim measure?
Comment 5 Adam Jackson 2005-12-13 11:34:41 UTC
not strong enough to block
Comment 6 Adam Jackson 2005-12-22 03:34:55 UTC
*** Bug 2601 has been marked as a duplicate of this bug. ***
Comment 7 Bernhard R. Link 2005-12-22 05:16:48 UTC
Is this really the same bug as 2601? Can a too low dotclock rate explain using
the wrong frequencies, especially different frequencies at different outputs?
Comment 8 Erik Andren 2006-04-18 05:09:31 UTC
Added patch keyword
Comment 9 Adam Jackson 2006-04-25 05:43:35 UTC
Assigning to idr for evaluation.  Probably going to move to 7.2 tracker if
there's no movement within about a week.
Comment 10 Adam Jackson 2006-05-16 23:33:18 UTC
(In reply to comment #9)
> Assigning to idr for evaluation.  Probably going to move to 7.2 tracker if
> there's no movement within about a week.

Keeping my word, move to 7.2.

I have some additional changes from matrox that we should look at for a stable
release relative to 7.1.
Comment 11 Daniel Stone 2006-11-04 09:57:21 UTC
ajax: ping re changes?
Comment 12 Daniel Stone 2006-12-16 09:30:46 UTC
... punting from tracker.
Comment 13 Tilman Sauerbeck 2006-12-16 09:43:20 UTC
*** Bug 2601 has been marked as a duplicate of this bug. ***
Comment 14 Daniel Stone 2007-02-27 01:27:44 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 15 Tilman Sauerbeck 2007-07-30 03:41:42 UTC
Fixed in 7d7626f8429e108dd326899d927de4b4c79f71f5.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.