Bug 4246 - Add DDC2 support for Voodoo3 chipsets ( and probably others )
Summary: Add DDC2 support for Voodoo3 chipsets ( and probably others )
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/tdfx (show other bugs)
Version: unspecified
Hardware: PowerPC NetBSD
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2005-08-25 14:09 UTC by Michael Lorenz
Modified: 2007-02-27 18:33 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

patch against NetBSD's xsrc (6.78 KB, patch)
2005-08-25 14:10 UTC, Michael Lorenz
no flags Details | Splinter Review

Description Michael Lorenz 2005-08-25 14:09:39 UTC
patch below adds DDC2/I2C support to the tdfx driver which has the distinct 
advantage to work anywhere since it doesn't depend on the vbe module. It will 
try DDC2 first and if that fails fall back to the old vbe stuff when possible. 
Moved mode validation and related stuff /after/ monitor detection. 
Tested on NetBSD/macppc with a voodoo3 ( with unofficial patches to allow PCI 
IO access, but these affect only the platform-specific PCI code, not the tdfx 
driver ) 
The patch is for NetBSD's xsrc which is based on XFree86 4.5 - maybe it's 
useful here too.
Comment 1 Michael Lorenz 2005-08-25 14:10:50 UTC
Created attachment 3034 [details] [review]
patch against NetBSD's xsrc
Comment 2 Luc Verhaegen 2006-03-09 02:27:38 UTC
Patch and driver could use a some indentation and Bus naming needs to be
changed. This bus is aimed at DDC, not at the BT869 or the VPX3224 found on 3000
and 3500s.

I2C Bus initialisation needs to be separated out from doTDFXDDC. In future we
will get DDC data more often, while we only need (all) busses initialised at
I'm not sure how well that will work with the rest of VIDSERIALPARALELPORT
though, and how restoration of it will proceed. Maybe the higher level i2c
functions should be used?
Comment 3 Daniel Stone 2007-02-27 01:27:43 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 4 Alex Deucher 2007-02-27 18:33:38 UTC
committed a cleaned up variation on this patch:

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.