Bug 41770 - Call: Transport property in Endpoint not well explained
Summary: Call: Transport property in Endpoint not well explained
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
Whiteboard: Call, review+ with some small fixes
Keywords: patch
Depends on:
Reported: 2011-10-13 16:09 UTC by Olivier Crête
Modified: 2011-12-23 08:25 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

patch to add documentation (1.86 KB, patch)
2011-12-14 13:16 UTC, Olivier Crête
Details | Splinter Review
correct patch to add doc (1.86 KB, patch)
2011-12-14 13:18 UTC, Olivier Crête
Details | Splinter Review
the right patch (999 bytes, patch)
2011-12-14 13:23 UTC, Olivier Crête
Details | Splinter Review

Description Olivier Crête 2011-10-13 16:09:16 UTC
The property is there in both.. I don't really see any use case where the different Endpoints wityh different transports on the same Stream.

Also, where is the ICE->rawudp fallback stuff gone from the Endpoint ? I'm sure we had figured out something clever, but I can't find it anymore.
Comment 1 Olivier Crête 2011-10-13 16:12:17 UTC
Actually, I think the Endpoint could have a different type than the Stream for the ICE->Rawudp fallback.. So we need to document that correctly.
Comment 2 Olivier Crête 2011-12-14 13:16:05 UTC
Created attachment 54432 [details] [review]
patch to add documentation

Here is a patch that makes it a bit clearer when the Transport oin the Stream and Endpoints can differ
Comment 3 Olivier Crête 2011-12-14 13:18:53 UTC
Created attachment 54433 [details] [review]
correct patch to add doc

oops, previous patch was invalid
Comment 4 Olivier Crête 2011-12-14 13:23:01 UTC
Created attachment 54434 [details] [review]
the right patch

also attach the right file...
Comment 5 Xavier Claessens 2011-12-16 04:10:45 UTC
Comment 6 Jonny Lamb 2011-12-23 01:13:22 UTC
Seems reasonable. Please fix up the indentation and ideally add some nice tp:value-ref'ing while you're at it.
Comment 7 Olivier Crête 2011-12-23 08:25:25 UTC
Done, odd indentation was due to tab-spaces mix.. oops !

commit 9485135a28310f16472ff79a889a2d697a83dd05
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Wed Dec 14 16:15:00 2011 -0500

    Call.Stream.Endpoint: Document when the Endpoint and Stream Transports can d

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.