Bug 41734 - Call: Contact duplicated in CodecOffer
Summary: Call: Contact duplicated in CodecOffer
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
Whiteboard: Call, review+
Keywords: patch
Depends on:
Reported: 2011-10-12 15:21 UTC by Olivier Crête
Modified: 2012-02-15 02:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

spec patch (1.86 KB, patch)
2011-12-14 13:10 UTC, Olivier Crête
Details | Splinter Review
correct patch to remove the duplicated contact (2.86 KB, patch)
2011-12-14 13:24 UTC, Olivier Crête
Details | Splinter Review
last one (986 bytes, patch)
2011-12-23 12:59 UTC, Olivier Crête
Details | Splinter Review

Description Olivier Crête 2011-10-12 15:21:24 UTC
In Call1.Content.Interface.Media, there is a type called Media_Description_Offer which contains a RemoteContact (a handle) and a map of the properties of Call1.Content.MediaDescription which alse contains a member called RemoteContact which is also a handle..

Is it duplicated? If so, then we should get rid of the Handle in the signals in Call1.Content.Interface.Media I guess.

Let's fix this now before I finish the Call1 port of tp-fs.
Comment 1 Olivier Crête 2011-12-14 13:10:18 UTC
Created attachment 54431 [details] [review]
spec patch

Here is a patch that just removes the extra remote contact handle from the signals and methods in Content.I.Media. Please discuss.
Comment 2 Olivier Crête 2011-12-14 13:24:43 UTC
Created attachment 54436 [details] [review]
correct patch to remove the duplicated contact

Again, put the right patch
Comment 3 Xavier Claessens 2011-12-16 04:10:23 UTC
This is cosmetical, but why not.
Comment 4 Jonny Lamb 2011-12-23 01:07:44 UTC
Merge away.
Comment 5 Olivier Crête 2011-12-23 08:21:20 UTC

ommit 725a680a48a88d1befbdf332f6ea61a8cf4743d3
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Wed Dec 14 16:06:15 2011 -0500

    Call.Content.I.Media: Remove duplicated Remote Contact
    The Remote contact object already present inside the MediaDescription object
Comment 6 Olivier Crête 2011-12-23 12:59:37 UTC
Created attachment 54756 [details] [review]
last one

oops, I forgot one..
Comment 7 Simon McVittie 2012-02-14 06:07:11 UTC
Is this going to disrupt finalizing Call? If not, r+.
Comment 8 Xavier Claessens 2012-02-15 02:36:23 UTC
Merged, was last diff between tp-spec and tp-glib' spec, except for the undraft.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.