Bug 40551 - Memory leak (Approval structs and/or contents thereof not freed)
Summary: Memory leak (Approval structs and/or contents thereof not freed)
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Vivek Dasmohapatra
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/vi...
Whiteboard: review+ once two patches have been sq...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-09-01 08:10 UTC by Vivek Dasmohapatra
Modified: 2011-09-07 08:36 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Vivek Dasmohapatra 2011-09-01 08:10:20 UTC 
24 bytes in 2 blocks are definitely lost in loss record 1,374 of 3,153
   at 0x4834EBC: malloc (vg_replace_malloc.c:236)
   by 0x4CFC053: g_malloc (gmem.c:164)
   by 0x4D151D7: g_slice_alloc (gslice.c:842)
   by 0x4D15553: g_slice_alloc0 (gslice.c:854)
   by 0x48A76CF: _mcd_dispatch_operation_dec_ado_pending (mcd-dispatch-operation.c:137)
   by 0x48A876B: mcd_dispatch_operation_idle_run_approvers (mcd-dispatch-operation.c:2225)
   by 0x4CF00DF: g_idle_dispatch (gmain.c:4545)

telepathy-mission-control/src/mcd-dispatch-operation.c:

   _mcd_dispatch_operation_finish
      g_queue_pop_head, but popped items are not freed

(And related code paths)
Comment 1 Will Thompson 2011-09-05 09:47:42 UTC 
Why do you add a newline in patch 2, and then remove it 2 patches later in a patch titled "whitespace trivia"?

The branch otherwise looks fine.
Comment 2 Vivek Dasmohapatra 2011-09-06 07:15:34 UTC 
(In reply to comment #1)
> Why do you add a newline in patch 2, and then remove it 2 patches later in a
> patch titled "whitespace trivia"?
> 
> The branch otherwise looks fine.

Fixed the whitespace thing, thanks.
Comment 3 Vivek Dasmohapatra 2011-09-07 08:36:15 UTC 
Released in 5.8.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.