Bug 40003 - fix build system and a regression test for Autoconf -> mingw cross-compilation
Summary: fix build system and a regression test for Autoconf -> mingw cross-compilation
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.4.x
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks: dbus-1.4
  Show dependency treegraph
 
Reported: 2011-08-11 03:38 UTC by Simon McVittie
Modified: 2011-08-12 02:49 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
[1/2] Fix linking of libdbus-testutils.la with Automake targeting Windows (1.14 KB, patch)
2011-08-11 03:39 UTC, Simon McVittie
Details | Splinter Review
[2/2] Fix compiler warnings when cross-compiling dbus-daemon test for mingw32 (1000 bytes, patch)
2011-08-11 03:39 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2011-08-11 03:38:39 UTC
Commit 9875480ed broke cross-compilation of Windows binaries using Autoconf and mingw, which I use to sanity-check patches that touch Windows code.

Vaguely relatedly, the dbus-daemon test doesn't use the GPid abstraction correctly, leading to compiler warnings (and probably total brokenness) on Windows.

(One day, I'd like to get a mingw build of D-Bus passing its regression tests under Wine. This is not that day, however.)
Comment 1 Simon McVittie 2011-08-11 03:39:16 UTC
Created attachment 50117 [details] [review]
[1/2] Fix linking of libdbus-testutils.la with Automake targeting Windows

This regressed in commit 9875480ed - libdbus-testutils.la needs static
linking too.
Comment 2 Simon McVittie 2011-08-11 03:39:45 UTC
Created attachment 50118 [details] [review]
[2/2] Fix compiler warnings when cross-compiling dbus-daemon test for mingw32
Comment 3 Colin Walters 2011-08-12 00:36:00 UTC
Review of attachment 50117 [details] [review]:

Looks right.
Comment 4 Colin Walters 2011-08-12 00:47:14 UTC
Review of attachment 50118 [details] [review]:

Looks good.
Comment 5 Simon McVittie 2011-08-12 02:49:17 UTC
(In reply to comment #1)
> Fix linking of libdbus-testutils.la with Automake targeting Windows

Unnecessary in 1.4.x; fixed in git for 1.5.8.

(In reply to comment #2)
> Fix compiler warnings when cross-compiling dbus-daemon test for mingw32

Fixed in git for 1.4.16 and 1.5.8. I also fixed the same warnings, with the same changes, in the very similar dbus-daemon-eavesdrop test, which only exists in master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.