Bug 40002 - avoid dead code in bus/main.c on non-Unix
Summary: avoid dead code in bus/main.c on non-Unix
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: Other All
: low trivial
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
Keywords: patch
Depends on:
Blocks: dbus-1.5
  Show dependency treegraph
Reported: 2011-08-11 03:34 UTC by Simon McVittie
Modified: 2011-08-26 07:17 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Don't build any of the reload-pipe code on non-Unix (1.71 KB, patch)
2011-08-11 03:34 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2011-08-11 03:34:33 UTC
Created attachment 50116 [details] [review]
Don't build any of the reload-pipe code on non-Unix

In commit ab7b3f9, Ralf notes that handle_reload_watch() is (in principle) cross-platform. However, there's no way to trigger it on Windows, because nothing ever writes to the pipe (the only way to reload on Windows is ReloadConfig(), which just does the reload there and then, without messing about with Unix signals). It seems cleaner to make the entire pipe-to-self trick Unix-specific instead.
Comment 1 Will Thompson 2011-08-25 10:32:47 UTC
Review of attachment 50116 [details] [review]:

This looks fine, ship it.
Comment 2 Simon McVittie 2011-08-26 07:17:52 UTC
Thanks, fixed in git for 1.4.16, 1.5.8

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.