Bug 39652 - Gabble crashes on connecting account (wocky_caps_hash_compute_from_node returns a NULL string)
Summary: Gabble crashes on connecting account (wocky_caps_hash_compute_from_node retur...
Status: RESOLVED DUPLICATE of bug 39464
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 18:28 UTC by Daniele E. Domenichelli
Modified: 2011-07-29 01:33 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Use tp_strdiff instead of g_str_equal (866 bytes, patch)
2011-07-28 18:28 UTC, Daniele E. Domenichelli 		Details | Splinter Review
View All

Description Daniele E. Domenichelli 2011-07-28 18:28:52 UTC 
Created attachment 49693 [details] [review]
Use tp_strdiff instead of g_str_equal

The problem is in presence-cache.c:1318

  if (g_str_equal (waiter_self->ver, computed_hash))

computed_hash = wocky_caps_hash_compute_from_node (query_result) and computed_hash is NULL

The attached patch fixes the crash using tp_strdiff instead of g_str_equal, but I don't know why wocky fails to compute hash, and I cannot reproduce the bug every time (and at the moment I cannot reproduce it to add a debug log to the bug report, sorry)
Comment 1 Will Thompson 2011-07-29 01:33:19 UTC 

*** This bug has been marked as a duplicate of bug 39464 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.