Compiling the xorg CVS sources (HEAD) gives lots of warnings about unused variables (Toolchain: gcc (GCC) 4.0.1 (Debian 4.0.1-2) on Debian unstable). E.g.: chooser.c: In function 'Hostselect': chooser.c:1050: warning: unused variable 'newy' Some variables are of external use or are #ifdeffed and those should not be touched. I created some patches which clean up variables not used inside functions at all. The patches (one per affected file) can be found compressed and packed in the URL section of this bug. The patches where done against CVS HEAD on Sat Jul 16 2005. It would be nice if the code can be cleaned up, with the help of the patches. Thanks!
Created attachment 3097 [details] Standalone testcase for the fbBlt() bug; link with /usr/X11R6/lib/modules/libfb.a Oh, I wasn't aware I could attach files to bugzilla :), so I attach the patches for the record and in case someone has problems accessing the URL.
Created attachment 3098 [details] [review] Patch that fixes the fbBlt() problem
Created attachment 3099 [details] [review] Fix for the problem
The patches previously attached were lost in the bugzilla disk death, and the web site listed is not responding. Please re-attach the patches (sorry about this - the disk responsible has been taken out and shot).
This is part of 4542, using sparse finds a whole lot more. Please help with #4542. *** This bug has been marked as a duplicate of 4542 ***
Reopening make it depend on 4542 and keep the bugs grouped so we can fix this all at once.
Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Closing due to the original patches being lost and inactivity. *** This bug has been marked as a duplicate of bug 4542 ***
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.