_mcd_master_account_replace_transport would accept
"no connection" as a successful replacement if no
account conditions were specified, triggering unwanted
This regresses support for connections which genuinely don't need an Internet connection, like the cellular connection in telepathy-ring; that function should still short-circuit for such connections.
(Longer-term - in 5.9? - we need to discard McdTransport entirely, and add a connectivity plugin API using mission-control-plugins that doesn't distribute the logic more or less randomly between MC and the plugin.)
(In reply to comment #1)
> This regresses support for connections which genuinely don't need an Internet
Regression fixed in latest commit.
Aaand now we handle the "no transport plugins" case too.
> + unconditional = n_conds == 0;
Parentheses for clarity, please. Other than that, this looks OK; I assume tests now pass?
> Parentheses for clarity, please. Other than that, this looks OK; I assume tests
> now pass?
Amended, and yes.
Released in 5.8.0