Bug 37790 - remove stub test functions
Summary: remove stub test functions
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium trivial
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://cgit.freedesktop.org/~smcv/dbu...
Whiteboard: review?
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-05-31 07:19 UTC by Simon McVittie
Modified: 2011-06-01 09:28 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
[PATCH 1/4] dbus-glib-tool: remove regression-test boilerplate which does nothing (2.01 KB, patch)
2011-05-31 07:19 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 2/4] _dbus_gidl_test: remove unused function which does nothing (850 bytes, patch)
2011-05-31 07:19 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 3/4] Remove _dbus_gutils_test, which didn't test anything (1.50 KB, patch)
2011-05-31 07:19 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 4/4] Remove _dbus_g_proxy_test, which isn't called and doesn't do anything (864 bytes, patch)
2011-05-31 07:20 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2011-05-31 07:19:12 UTC 
Created attachment 47368 [details] [review]
[PATCH 1/4] dbus-glib-tool: remove regression-test boilerplate which  does nothing

See patches.
Comment 1 Simon McVittie 2011-05-31 07:19:34 UTC 
Created attachment 47369 [details] [review]
[PATCH 2/4] _dbus_gidl_test: remove unused function which does   nothing
Comment 2 Simon McVittie 2011-05-31 07:19:51 UTC 
Created attachment 47370 [details] [review]
[PATCH 3/4] Remove _dbus_gutils_test, which didn't test anything
Comment 3 Simon McVittie 2011-05-31 07:20:18 UTC 
Created attachment 47371 [details] [review]
[PATCH 4/4] Remove _dbus_g_proxy_test, which isn't called and  doesn't do anything
Comment 4 Will Thompson 2011-06-01 09:08:15 UTC 
Review of attachment 47368 [details] [review]:

++
Comment 5 Will Thompson 2011-06-01 09:09:10 UTC 
Review of attachment 47369 [details] [review]:

++
Comment 6 Will Thompson 2011-06-01 09:14:05 UTC 
Review of attachment 47370 [details] [review]:

++
Comment 7 Will Thompson 2011-06-01 09:17:03 UTC 
Review of attachment 47371 [details] [review]:

Go go go.
Comment 8 Simon McVittie 2011-06-01 09:28:02 UTC 
Thanks, fixed in git for 0.94

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.