Bug 37789 - clean up unnecessary bits from build system
Summary: clean up unnecessary bits from build system
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium trivial
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://cgit.freedesktop.org/~smcv/dbu...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-05-31 07:02 UTC by Simon McVittie
Modified: 2011-06-01 09:19 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
[PATCH 1/5] Add more auto-generated gtkdoc droppings to .gitignore (786 bytes, patch)
2011-05-31 07:03 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 2/5] Simplify the check for dbus-1 (1.17 KB, patch)
2011-05-31 07:03 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 3/5] Remove vestigial dbus-glib-error-*.h and the machinery to generate them (3.86 KB, patch)
2011-05-31 07:03 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 4/5] Remove unused DBUS_DAEMONDIR (1.07 KB, patch)
2011-05-31 07:04 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 5/5] Remove useless HAVE_GLIB conditional - GLib is mandatory (850 bytes, patch)
2011-05-31 07:04 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2011-05-31 07:02:47 UTC 
See patches.
Comment 1 Simon McVittie 2011-05-31 07:03:22 UTC 
Created attachment 47363 [details] [review]
[PATCH 1/5] Add more auto-generated gtkdoc droppings to .gitignore
Comment 2 Simon McVittie 2011-05-31 07:03:42 UTC 
Created attachment 47364 [details] [review]
[PATCH 2/5] Simplify the check for dbus-1

As in commit 0f782b4, omitting the action-if-found and action-if-not-found
results in much better error messages if this mandatory dependency isn't
found.

Nothing checks HAVE_DBUS (as they shouldn't - it's mandatory!), so there's
no point in keeping that either.
Comment 3 Simon McVittie 2011-05-31 07:03:59 UTC 
Created attachment 47365 [details] [review]
[PATCH 3/5] Remove vestigial dbus-glib-error-*.h and the machinery  to generate them

This was the only use of DBUS_INCLUDEDIR, so remove that too.
Comment 4 Simon McVittie 2011-05-31 07:04:14 UTC 
Created attachment 47366 [details] [review]
[PATCH 4/5] Remove unused DBUS_DAEMONDIR
Comment 5 Simon McVittie 2011-05-31 07:04:30 UTC 
Created attachment 47367 [details] [review]
[PATCH 5/5] Remove useless HAVE_GLIB conditional - GLib is mandatory
Comment 6 Will Thompson 2011-06-01 08:59:40 UTC 
Review of attachment 47363 [details] [review]:

++
Comment 7 Will Thompson 2011-06-01 09:00:25 UTC 
Review of attachment 47364 [details] [review]:

++
Comment 8 Will Thompson 2011-06-01 09:05:55 UTC 
Review of attachment 47365 [details] [review]:

Looks fine!
Comment 9 Will Thompson 2011-06-01 09:06:33 UTC 
Review of attachment 47366 [details] [review]:

Looks fine.
Comment 10 Will Thompson 2011-06-01 09:06:59 UTC 
Review of attachment 47367 [details] [review]:

++
Comment 11 Simon McVittie 2011-06-01 09:19:36 UTC 
Thanks, fixed in git for 0.94.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.