Created attachment 45867 [details] [review] patch to make internationalization conditional Build fails without internationalization support. Attached patch makes gettext usage conditional on the ENABLE_NLS macro.
For dbus-glib.c and dbus-gmain.c I'd prefer to take this commit from Bug #10890 (assuming someone will review it), since literally nothing in those files is marked for translation: http://cgit.collabora.co.uk/git/user/smcv/dbus-glib-smcv.git/commit/?id=09109a115935a8f9ac9e161e5dc02a136adfc8fd For dbus-gvalue.c and dbus-gproxy.c, your changes make sense. I'd prefer the #ifdef to be a separate "paragraph" below the rest of the #includes, like it is in dbus-glib.c and dbus-gmain.c. I doubt anyone has ever translated dbus-glib, and none of the translatable strings (which are all GError messages) are really comprehensible to the average user (or to programmers who aren't D-Bus specialists, in most cases), so I'm tempted to just rip out all the i18n support.
Created attachment 47360 [details] [review] Remove i18n macros from files where they're not used
Created attachment 47361 [details] [review] Remove support for i18n completely As far as I can tell, dbus-glib has never actually been translated into another language, or even had the necessary infrastructure so people could do that. The translated strings are all low-level errors in "programmer English" anyway, and most of them only make sense to D-Bus experts.
I think the best way to fix this is to bin i18n entirely; review would be appreciated.
Review of attachment 47360 [details] [review]: Looks fine.
Review of attachment 47361 [details] [review]: I hope you automated writing this patch! Looks fine.
Thanks, fixed in git for 0.94.
Created attachment 47458 [details] [review] remove include <glib/gi18n.h> Two files still included gi18n.h
Thanks, patch applied for 0.96.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.