Bug 35415 - Allow the UI to specify extra-identities account paramaters.
Summary: Allow the UI to specify extra-identities account paramaters.
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/st...
Whiteboard:
Keywords: patch
Depends on: 35410
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-18 05:18 UTC by Stef Walter
Modified: 2011-03-31 11:11 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Stef Walter 2011-03-18 05:18:51 UTC 
These are used as reference identities when checking the server certificate. These extra identities must result from user choices such as a selection of account type.

Will implement the changes to empathy in another bug.
Comment 1 Stef Walter 2011-03-18 10:11:05 UTC 
Added tests in my extra-identities branch (rebased).
Comment 2 Stef Walter 2011-03-21 04:16:39 UTC 
Changed param name 'extra-identities' to 'extra-certificate-identities'
Comment 3 Will Thompson 2011-03-31 10:51:45 UTC 
Just some style points:

http://git.collabora.co.uk/?p=user/stefw/telepathy-gabble.git;a=commitdiff;h=67837b88d14a70769ec65a159d36e53078b69351#patch3

Why not initialize those variables to NULL when they're declared? Not a big thing though.

+  if (explicit_server != NULL && !tp_str_empty (explicit_server) &&

tp_str_empty checks for NULL so you don't have to.

Also I think this will conflict with the extra style patches you added to the bug 35410 branch.
Comment 4 Will Thompson 2011-03-31 11:11:07 UTC 
Merged, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.