Bug 35335 - Add sidecar support
Summary: Add sidecar support
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.freedesktop.org/~jonny/te...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-03-15 08:31 UTC by Jonny Lamb
Modified: 2011-03-21 02:01 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Jonny Lamb 2011-03-15 08:31:32 UTC
Plugins are way old school now, let's be having sidecar support PLZ.

Here is an artist's impression of what salut with sidecars would look like:

http://people.collabora.co.uk/~jonny/salut-with-sidecars.jpg
Comment 1 Will Thompson 2011-03-18 10:14:45 UTC
+  if (!salut_plugin_implements_sidecar (plugin, sidecar_interface))
+    g_simple_async_report_error_in_idle (G_OBJECT (plugin), callback,
+        user_data, TP_ERRORS, TP_ERROR_NOT_IMPLEMENTED,
+        "Salut is buggy: '%s' doesn't implement sidecar %s",
+        iface->name, sidecar_interface);
+  else if (iface->create_sidecar == NULL)
+    g_simple_async_report_error_in_idle (G_OBJECT (plugin), callback,
+        user_data, TP_ERRORS, TP_ERROR_NOT_IMPLEMENTED,
+        "'%s' is buggy: it claims to implement %s, but does not implement "
+        "create_sidecar", iface->name, sidecar_interface);

These could use TP_ERROR_CONFUSED maybe?

But basically fine.
Comment 2 Jonny Lamb 2011-03-21 02:01:25 UTC
Perfetto!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.