Bug 35059 - Patch for India Malayalam enhanced inscript layout with Indian Rupee Sign
Summary: Patch for India Malayalam enhanced inscript layout with Indian Rupee Sign
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium enhancement
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords: NEEDINFO
Depends on:
Blocks:
 
Reported: 2011-03-06 06:03 UTC by Mahesh T Pai
Modified: 2011-03-08 09:34 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Patch for symbols/in file (2.80 KB, patch)
2011-03-06 06:03 UTC, Mahesh T Pai
Details | Splinter Review
Patch for rules/base.xml (299 bytes, patch)
2011-03-06 06:07 UTC, Mahesh T Pai
Details | Splinter Review
patch for rules/base (51 bytes, patch)
2011-03-06 06:09 UTC, Mahesh T Pai
Details | Splinter Review
Patch for rules/evdev.xml (51 bytes, patch)
2011-03-06 06:10 UTC, Mahesh T Pai
Details | Splinter Review
Patches for rules base.xml.in (301 bytes, patch)
2011-03-06 07:09 UTC, Mahesh T Pai
Details | Splinter Review

Description Mahesh T Pai 2011-03-06 06:03:33 UTC
Created attachment 44168 [details] [review]
Patch for symbols/in file

The layout is described in this image file:-

http://www.nongnu.org/smc/docs/images/ml_inscript_layout.jpg

This was been mandated by the Government of Kerala long time back - see:-

http://www.cs.princeton.edu/~mp/malayalam/keyboard/malayalam%20standardization%20report.pdf

The main difference bettween the present "mal" keyboard is that it uses the zwj to form the "chillu" characters; but with unicode version 5.1 and above, the chillus have been assigned separate code points ("atomic chillus"), and these have been added to the proposed keyboard layout. 

The other main difference is use of the "au" vowel marker from the reformed script. Since the older layout will continue to be available, users preferring to use old form of chillus and / or old /au/ vowel marker can continue to use the default, traditional Inscript layout. 

The new layout also implements the new Indian rupee sign (₹), which was not available in the Malayalam layouts. 

The atomic chillus are already implemented in m17n "Mozhi" keymap, which is available (probably, as optional) with Ubuntu  and Debian, and also other GNU/Linux distros. 

In the proprietary world, several kaymaps have already implemented Unicode version 5.2 (atomic chillus) and probably the Indian rupee sign too. 

One layout which implements the atomic chillus can be found here:-

http://www.supersoftweb.com/ThoolikaUnicode.aspx

Fonts which with atomic chillus already ship with Debian. 

I cannot figure out how to attach multiple attachments to this report, so will add patches for rules/*.xml files later.
Comment 1 Mahesh T Pai 2011-03-06 06:07:53 UTC
Created attachment 44169 [details] [review]
Patch for rules/base.xml

Adding patch for rules/base.xml

Not sure if patches for rules/evdev.xml and rules/base are reqoired. will add them in next post anyway.
Comment 2 Mahesh T Pai 2011-03-06 06:09:34 UTC
Created attachment 44170 [details] [review]
patch for rules/base

Patch for rules/base
Comment 3 Mahesh T Pai 2011-03-06 06:10:37 UTC
Created attachment 44171 [details] [review]
Patch for rules/evdev.xml

Patch for rules/evdev.xml
Comment 4 Sergey V. Udaltsov 2011-03-06 06:25:26 UTC
Thanks for your contribution!

Unfortunately you're patching wrong files - they are results of the build process. Could you please provide patches for base.xml.in, and base.*.part files?

Thank you
Comment 5 Mahesh T Pai 2011-03-06 06:39:44 UTC
(In reply to comment #4)

> Could you please provide patches for base.xml.in, and base.*.part
> files?

Certainly yes; looking at those files now. 

What about symbols/in ? Will the submitted patch do?
Comment 6 Sergey V. Udaltsov 2011-03-06 06:44:53 UTC
For a moment, the patch for symbols/in looks ok.
Comment 7 Mahesh T Pai 2011-03-06 07:09:06 UTC
Created attachment 44175 [details] [review]
Patches for rules base.xml.in

The patch is against base.xml.in from 

http://xlibs.freedesktop.org/xkbdesc/xkeyboard-config-2.0.tar.bz2
Comment 8 Mahesh T Pai 2011-03-06 07:22:59 UTC
I cannot figure out what to do about the base.*.part thing you mentioned. 

I tried doing a `grep -i mal ./* in rules/ directory, and only result, apart from base.xml.in is base.lists.part. 

Did I miss something? 

I am very sorry - I am only doing this for my own use - just submitting the modifications upstream; I am not a software guy, just that I have been using Debian for close to 10 years now.
Comment 9 Sergey V. Udaltsov 2011-03-06 07:25:16 UTC
Well, first of all - it would be better if patches were made not against the stable release but against git. I will try to accomodate your patch for base.xml.in

Regarding the base file - what exactly do you want to achieve with your original patch for rules/base?
Comment 10 Mahesh T Pai 2011-03-06 07:39:27 UTC
(In reply to comment #9)
> Well, first of all - it would be better if patches were made not against the
> stable release but against git. I will try to accomodate your patch for
> base.xml.in
> 

Err.... emmm... I was thinking that I am working only with plain text files; I remember simply modifying the files in symbols/ and things worked; of course, I had not figured out how to submit the patches upstreak. 

I have never used git so far; and even using svn / cvs will take me one or two hours to figure out - not that I cannot do it. 


Again, apologies. 

> Regarding the base file - what exactly do you want to achieve with your
> original patch for rules/base?

<feeling sheepish>

Dunno; just found the existing two layouts (mal and mal_lalitha) listed in the files, and thought that the proposed layout too should be added in those files too.
Comment 11 Sergey V. Udaltsov 2011-03-07 12:48:46 UTC
Ok, do not bother. Your patch is settled in git

One, hopefully final, question: are you sure that people will always want to use Rupee as RAlt-4? I am asking because we already have xkb option that triggers that mapping - perhaps people could set it explicitly? In that case, if, say, tomorrow someone asks for Rupee as RAlt-5, we won't have to remove that mapping.

Also, next time, please do "diff -u". In your current format the patches are incorrect:)
Comment 12 Mahesh T Pai 2011-03-08 09:34:35 UTC
(In reply to comment #11)
> Ok, do not bother. Your patch is settled in git

Thanks. 

> One, hopefully final, question: 

I will be happy to answer any number of questions from upstream deelopers; that is only way I can repay you. ;-D

> are you sure that people will always want to
> use Rupee as RAlt-4? I am asking because we already have xkb option that
> triggers that mapping - perhaps people could set it explicitly? In that case,
> if, say, tomorrow someone asks for Rupee as RAlt-5, we won't have to remove
> that mapping.

This (people asking for different key for the ₹ sign) is highly unlikely. 

AFAIK, while the layout for language may vary, position for characters like !, @, #, &, ?,  etc. rarely changes. I guess same logic would apply to the Rupee symbol. 

The position is also proposed as common across Indian English keyboard and Inscript layouts for Indic languages. This _proposal_ can be found at 

http://malayalam.kerala.gov.in/images/8/80/Qwerty_enhancedinscriptkeyboardlayout.pdf

(t is available after a registration process on C-DAC's web site. 


> Also, next time, please do "diff -u". In your current format the patches are
> incorrect:)

Definitely yes. Will note it.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.