Bug 34672 - configure.ac unnecessarily uses changequote
Summary: configure.ac unnecessarily uses changequote
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.4.x
Hardware: Other All
: medium minor
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-02-24 09:11 UTC by Simon McVittie
Modified: 2011-02-28 06:29 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
[PATCH 1/3] Use square brackets (m4 quoting) instead of changequote (1.15 KB, patch)
2011-02-24 09:11 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 2/3] Remove unnecessary changequote call (849 bytes, patch)
2011-02-24 09:11 UTC, Simon McVittie 		Details | Splinter Review
[PATCH 3/3] Don't compress spaces in CFLAGS and friends (954 bytes, patch)
2011-02-24 09:12 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2011-02-24 09:11:08 UTC 
From the department of "how clean is your configure.ac?". See:

http://www.gnu.org/software/autoconf/manual/html_node/Changequote-is-Evil.html

or the branch referenced in the URL field.
Comment 1 Simon McVittie 2011-02-24 09:11:41 UTC 
Created attachment 43759 [details] [review]
[PATCH 1/3] Use square brackets (m4 quoting) instead of changequote
Comment 2 Simon McVittie 2011-02-24 09:11:59 UTC 
Created attachment 43760 [details] [review]
[PATCH 2/3] Remove unnecessary changequote call

Nothing in the changequote'd environment uses square brackets anyway.
Comment 3 Simon McVittie 2011-02-24 09:12:22 UTC 
Created attachment 43761 [details] [review]
[PATCH 3/3] Don't compress spaces in CFLAGS and friends

Not all sed implementations understand "+" with its POSIX extended regular
expression semantics, and compressing spaces is purely cosmetic anyway.
Let's just drop this.
Comment 4 Will Thompson 2011-02-25 03:03:13 UTC 
Review of attachment 43759 [details] [review]:

I think this makes the section less opaque. So ship it.
Comment 5 Will Thompson 2011-02-25 03:04:55 UTC 
Review of attachment 43760 [details] [review]:

Ship it.
Comment 6 Will Thompson 2011-02-25 03:05:55 UTC 
Review of attachment 43761 [details] [review]:

Fine!
Comment 7 Simon McVittie 2011-02-28 06:29:14 UTC 
Fixed in git for 1.4.8, 1.5.0. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.