Bug 32854 - potential symlink attack when compiling dbus
Summary: potential symlink attack when compiling dbus
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.4.x
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2011-01-05 11:17 UTC by Simon McVittie
Modified: 2011-01-14 07:22 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
configure.in: use AC_TRY_COMPILE to avoid a symlink attack in /tmp during compilation (1.04 KB, patch)
2011-01-05 11:17 UTC, Simon McVittie 		Details | Splinter Review
Fix the check for -Wfloat-equal (681 bytes, patch)
2011-01-05 11:18 UTC, Simon McVittie 		Details | Splinter Review
cmake/cross-compile.sh: use mktemp(1) to avoid a symlink attack in /tmp (1.56 KB, patch)
2011-01-05 11:18 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2011-01-05 11:17:14 UTC 
I happened to notice that configure.in writes semi-predictable filenames into /tmp, which is bad for all the usual reasons.
Comment 1 Simon McVittie 2011-01-05 11:17:57 UTC 
Created attachment 41680 [details] [review]
configure.in: use AC_TRY_COMPILE to avoid a symlink attack in /tmp during compilation
Comment 2 Simon McVittie 2011-01-05 11:18:24 UTC 
Created attachment 41681 [details] [review]
Fix the check for -Wfloat-equal
Comment 3 Simon McVittie 2011-01-05 11:18:41 UTC 
Created attachment 41682 [details] [review]
cmake/cross-compile.sh: use mktemp(1) to avoid a symlink attack in /tmp
Comment 4 Simon McVittie 2011-01-05 11:19:42 UTC 
These should probably go to 1.2 too. I haven't done the CVE-number dance since these only apply when compiling dbus, not when using it (and cmake/cross-compile.sh isn't used by default).
Comment 5 Simon McVittie 2011-01-14 07:19:51 UTC 
15:14 < wjt> smcv: tmp looks fine
15:15 < wjt> smcv: as does trivia

Fixed in git for 1.4.4 or 1.5.0.
Comment 6 Simon McVittie 2011-01-14 07:22:23 UTC 
... and in the 1.2 branch for 1.2.28 (only the AC_TRY_COMPILE patch there).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.