Bug 32682 - Inverted check in tseng driver makes it fail to detect card
Summary: Inverted check in tseng driver makes it fail to detect card
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Tseng Labs (show other bugs)
Version: git
Hardware: Other Linux (All)
: medium major
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-27 05:53 UTC by BALATON Zoltan
Modified: 2011-06-11 03:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch correcting typo in TsengGetFbAddress (700 bytes, patch)
2010-12-27 05:55 UTC, BALATON Zoltan 		no flags Details | Splinter Review
View All

Description BALATON Zoltan 2010-12-27 05:53:26 UTC 
Due to a typo in TsengGetFbAddress it is unable to get framebuffer base address and thus fails to load with an error message saying "No valid Framebuffer address in PCI config space" although previously it does print the correct framebuffer address. The attached patch corrects this and makes the driver work again.
Comment 1 BALATON Zoltan 2010-12-27 05:55:05 UTC 
Created attachment 41473 [details] [review]
Patch correcting typo in TsengGetFbAddress
Comment 2 Julien Cristau 2011-06-11 03:54:05 UTC 
Committed, finally.  Thanks for the patch!

commit 542e65deaf834c3d58c44064206445e4d18f6daa
Author: BALATON Zoltan <balaton@eik.bme.hu>
Date:   Sat Jun 11 12:50:16 2011 +0200

    Fix regression from pciaccess conversion (bug#32682)
    
    Due to a typo in TsengGetFbAddress it is unable to get framebuffer base
    address and thus fails to load with an error message saying "No valid
    Framebuffer address in PCI config space" although previously it does
    print the correct framebuffer address.
    
    Signed-off-by: Julien Cristau <jcristau@debian.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.