Bug 32411 - tp_g_signal_connect_object should complain if you use unsupported flags
Summary: tp_g_signal_connect_object should complain if you use unsupported flags
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: low minor
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-12-15 06:04 UTC by Simon McVittie
Modified: 2010-12-16 03:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-12-15 06:04:59 UTC 
tp_g_signal_connect_object needs specific support for any connect-flags. It currently supports both the flags that exist in GLib (SWAPPED and AFTER) and is documented as such. However, if the GLib developers add more, we should stop people trying to use them until we've added support for them.

This branch makes it return_if_fail if you disobey the documentation.
Comment 1 Jonny Lamb 2010-12-16 00:28:40 UTC 
Seems reasonable.
Comment 2 Simon McVittie 2010-12-16 03:18:20 UTC 
Thanks, fixed in git for 0.13.10

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.