The check for _dbus_close in _dbus_pipe_close is bogus, as it checks for < 0, whereas a boolean is returned.
Created attachment 40952 [details] [review] Fix error condition in _dbus_pipe_close
Review of attachment 40952 [details] [review]: ::: dbus/dbus-pipe-unix.c @@ +72,3 @@ DBusError *error) { + if (_dbus_close (pipe->fd_or_handle, error)) Shouldn't there be a "!" in there?
Created attachment 40954 [details] [review] Fix error condition in _dbus_pipe_close #2 Oops, indeed.
Review of attachment 40954 [details] [review]: Looks good, thanks! (And sorry for the duplicate reviews, splinter was having a bad day)
I applied this to master, it'll be in 1.4.4 (or possibly 1.5.0).
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.