Bug 31874 - implement Chan.T.ServerAuthentication, Chan.I.SASLAuthentication in Gabble
Summary: implement Chan.T.ServerAuthentication, Chan.I.SASLAuthentication in Gabble
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: 0.11
Hardware: Other All
: high enhancement
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Keywords: patch
Depends on: 14003
  Show dependency treegraph
Reported: 2010-11-23 12:46 UTC by Simon McVittie
Modified: 2010-11-30 09:17 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2010-11-23 12:46:01 UTC
Here's a branch to refactor SASL support, and implement the latest draft of SASLAuthentication from Bug #14003, in Gabble.

As suggested by wjt on the spec bug, it no longer advertises support for X-WOCKY-JABBER-* over D-Bus - if we're doing legacy Jabber authentication, the only option is X-TELEPATHY-PASSWORD, which does some GAsyncResult gymnastics to chain up to the base-class implementation.
Comment 1 Jonny Lamb 2010-11-24 06:45:29 UTC
Big big branch
Comment 2 Jonny Lamb 2010-11-24 06:45:54 UTC
I reviewed up to e32ebab6c848e7.
Comment 3 Simon McVittie 2010-11-24 08:48:28 UTC
The bad news is, there are 17 more patches. The good news is, the changes are pretty small and mostly only touch the tests...
Comment 4 Simon McVittie 2010-11-24 10:40:34 UTC
Branch merged, awaiting spec/tp-glib support for the undrafted API.
Comment 5 Simon McVittie 2010-11-25 08:58:23 UTC
o hai I heard you liked undraft
Comment 6 Jonny Lamb 2010-11-25 10:10:09 UTC
Well that branch is fine, but why don't you just depend on the newer tp-glib and use its generated code? It's already released?
Comment 7 Simon McVittie 2010-11-26 05:05:21 UTC
(In reply to comment #6)
> Well that branch is fine, but why don't you just depend on the newer tp-glib
> and use its generated code? It's already released?

Because I did this branch in parallel with releasing telepathy-glib :-)

I've merged the minimal version, and updated the branch with a version that uses telepathy-glib 0.13.7 for both SASL and PowerSaving (this incidentally also fixes a missing dependency on 0.13.7 needed by the branch from Bug #31106).
Comment 8 Jonny Lamb 2010-11-29 03:36:00 UTC
This all looks fine except that you've missed out another place where you added a FIXME to use ServiceConfused when available: map_wocky_auth_error in error.c.

Other than that, ++.
Comment 9 Simon McVittie 2010-11-30 09:08:56 UTC
Two more commits, using Confused and ServerConfused in error.c where appropriate.
Comment 10 Simon McVittie 2010-11-30 09:17:53 UTC
Fixed in git for 0.11.3

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.