Here's a branch to refactor SASL support, and implement the latest draft of SASLAuthentication from Bug #14003, in Gabble.
As suggested by wjt on the spec bug, it no longer advertises support for X-WOCKY-JABBER-* over D-Bus - if we're doing legacy Jabber authentication, the only option is X-TELEPATHY-PASSWORD, which does some GAsyncResult gymnastics to chain up to the base-class implementation.
Big big branch
I reviewed up to e32ebab6c848e7.
The bad news is, there are 17 more patches. The good news is, the changes are pretty small and mostly only touch the tests...
Branch merged, awaiting spec/tp-glib support for the undrafted API.
o hai I heard you liked undraft
Well that branch is fine, but why don't you just depend on the newer tp-glib and use its generated code? It's already released?
(In reply to comment #6)
> Well that branch is fine, but why don't you just depend on the newer tp-glib
> and use its generated code? It's already released?
Because I did this branch in parallel with releasing telepathy-glib :-)
I've merged the minimal version, and updated the branch with a version that uses telepathy-glib 0.13.7 for both SASL and PowerSaving (this incidentally also fixes a missing dependency on 0.13.7 needed by the branch from Bug #31106).
This all looks fine except that you've missed out another place where you added a FIXME to use ServiceConfused when available: map_wocky_auth_error in error.c.
Other than that, ++.
Two more commits, using Confused and ServerConfused in error.c where appropriate.
Fixed in git for 0.11.3