Bug 31665 - stop using tp_get_bus() in Salut
Summary: stop using tp_get_bus() in Salut
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: salut (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: r+
Keywords: patch
Depends on:
Blocks: 24114
  Show dependency tree / graph
 
Reported: 2010-11-16 09:14 UTC by Simon McVittie
Modified: 2010-11-18 03:25 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-11-16 09:14:14 UTC 
+++ This bug was initially created as a clone of Bug #24114 +++

tp_get_bus() calls exit(), which is Bad™. We can't remove it til we break ABI, but we can at least deprecate it.

Salut still uses this function; it shouldn't.

This Gabble commit should illustrate how to avoid it:

http://git.collabora.co.uk/?p=telepathy-gabble.git;a=commitdiff;h=59319365a14e0f62407a44191b386b1d581083fa
Comment 1 Simon McVittie 2010-11-17 09:49:03 UTC 
+patch
Comment 2 Guillaume Desmottes 2010-11-17 10:54:35 UTC 
++
Comment 3 Simon McVittie 2010-11-18 03:25:53 UTC 
Fixed in git for 0.5.0

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.