Bug 31664 - stop using tp_get_bus() in Ring
Summary: stop using tp_get_bus() in Ring
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: ring (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Pekka Pessi
QA Contact: Telepathy bugs list
URL: http://cgit.freedesktop.org/~smcv/tel...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 24114
  Show dependency tree / graph
 
Reported: 2010-11-16 09:11 UTC by Simon McVittie
Modified: 2010-12-01 03:34 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
untested patch (2.27 KB, patch)
2010-11-17 09:36 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2010-11-16 09:11:51 UTC 
+++ This bug was initially created as a clone of Bug #24114 +++

tp_get_bus() calls exit(), which is Bad™. We can't remove it til we break ABI, but we can at least deprecate it.

telepathy-ring still uses this function; it shouldn't.

This Gabble commit should illustrate how to avoid it:

http://git.collabora.co.uk/?p=telepathy-gabble.git;a=commitdiff;h=59319365a14e0f62407a44191b386b1d581083fa
Comment 1 Simon McVittie 2010-11-17 09:35:47 UTC 
An untested branch will be on http://cgit.freedesktop.org/~smcv/telepathy-ring when cgit updates.
Comment 2 Simon McVittie 2010-11-17 09:36:30 UTC 
Created attachment 40340 [details] [review]
untested patch
Comment 3 Pekka Pessi 2010-11-24 12:00:35 UTC 
The patch looks pretty good, and seems to work with slight changes. Thanks.
Comment 4 Simon McVittie 2010-12-01 03:34:31 UTC 
This appears to be fixed in git for 2.1.1, so it no longer blocks deprecating the function. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.