Bug 31430 - unhandled content-types on first switchboard message
Summary: unhandled content-types on first switchboard message
Status: NEW
Alias: None
Product: papyon
Classification: Unclassified
Component: general (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: papyon-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-06 06:36 UTC by Riccardo (c10ud)
Modified: 2010-11-06 06:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Riccardo (c10ud) 2010-11-06 06:36:48 UTC
[14:14] <c10ud> lfrb, seems like papyon isn't parsing received msn_objects at all on first switchboard message..quite strange, i'm now seeing if i can track down where shit happens
[14:22] <c10ud> lfrb, the first switchboard message, if Content-Type: 'text/x-mms-animemoticon', is not handled at all by conversation's _on_message_received
[14:33] <c10ud> ok, found: conversation.py@430 you can safely not filter text/x-mms-(anim)emoticon when switchboard_handler is None, just tried and it worked good.
[14:33] <c10ud> *switchboard_client

--- a/papyon/conversation.py
+++ b/papyon/conversation.py
@@ -427,7 +427,7 @@ class SwitchboardConversation(AbstractConversation, SwitchboardHandler):
     def _can_handle_message(message, switchboard_client=None):
         content_type = message.content_type[0]
         if switchboard_client is None:
-            return content_type in ('text/plain', 'text/x-msnmsgr-datacast')
+            return content_type in ('text/plain', 'text/x-msnmsgr-datacast', 'text/x-mms-emoticon', 'text/x-mms-animemoticon')
         # FIXME : we need to not filter those 'text/x-mms-emoticon', 'text/x-mms-animemoticon'
         return content_type in ('text/plain', 'text/x-msmsgscontrol',
                 'text/x-msnmsgr-datacast', 'text/x-mms-emoticon',


hope to have it in next bugfix rel :)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.