Bug 31385 - stop using "Loudmouth" in the roster
Summary: stop using "Loudmouth" in the roster
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: 0.11
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-11-04 09:58 UTC by Simon McVittie
Modified: 2010-11-19 11:11 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Simon McVittie 2010-11-04 09:58:44 UTC 
Gabble is gradually migrating from a Loudmouth-compatible API shim to the underlying Wocky API. Since roster.c has already changed a lot in 0.11, there's not much point in leaving it with the "LM" API - we'll have to backport any changes anyway.

http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/wockify-roster
Comment 1 Will Thompson 2010-11-05 10:49:43 UTC 
+static void
+roster_received_cb (GObject *source_object,
+    GAsyncResult *result,
+    gpointer weak_ref)
 {

I think this leaks the GabbleRoster reference.

Otherwise looks kosher. Good stuff for ploughing through this. :)
Comment 2 Simon McVittie 2010-11-08 07:42:58 UTC 
(In reply to comment #1)
> I think this leaks the GabbleRoster reference.

Good catch, fixed.
Comment 3 Will Thompson 2010-11-19 09:48:46 UTC 
ogogogogo go go ogo go go go go o gogo go ooggo oo o
Comment 4 Simon McVittie 2010-11-19 11:11:01 UTC 
0.11.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.