Patch posted on the dbus mailing list: http://lists.freedesktop.org/archives/dbus/2010-October/013635.html

Created attachment 39878 [details] [review]
[PATCH] policy: check against primary group as well, not just auxiliary groups (fd.o#30938)

Attaching the patch to this bug as well now since I didn't get any reply on the mailing list.

(In reply to comment #2)
> [PATCH] policy: check against primary group as well, not just auxiliary
> groups (fd.o#30938)

Is this still wrong in 1.6.x? On what operating system?

As far as I can see, DBusUserInfo.group_ids is meant to be filled with all the groups (specifically including the primary GID), but fill_user_info() in dbus-sysdeps-unix.c omits the primary GID on the HAVE_GETGROUPLIST code path. I'd prefer to fix it in fill_user_info() rather than working around it elsewhere.

Created attachment 84739 [details] [review]
Add a manual test for user/group info on Unix

---

This seems to work fine for me, on Debian unstable (early development of Debian 8) with Linux 3.10 and glibc 2.17. I get my primary group ID in both primary_gid and group_ids[0], as documented.

(In reply to comment #3)
> (In reply to comment #2)
> > [PATCH] policy: check against primary group as well, not just auxiliary
> > groups (fd.o#30938)
> 
> Is this still wrong in 1.6.x? On what operating system?
> 
> As far as I can see, DBusUserInfo.group_ids is meant to be filled with all
> the groups (specifically including the primary GID), but fill_user_info() in
> dbus-sysdeps-unix.c omits the primary GID on the HAVE_GETGROUPLIST code
> path. I'd prefer to fix it in fill_user_info() rather than working around it
> elsewhere.

I see on the HAVE_GETGROUPLIST code path in fill_user_info() call getgrouplist(3) to fill user group list. Which does return the primary group as well auxiliary groups.

(In reply to comment #3)
> Is this still wrong in 1.6.x? On what operating system?

Please answer, and preferably try the manual test that I attached.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/dbus/dbus/issues/32.