Bug 30841 - tests for interactive SASL and TLS crash due to Wocky update
Summary: tests for interactive SASL and TLS crash due to Wocky update
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium blocker
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-10-13 11:14 UTC by Simon McVittie
Modified: 2010-10-13 11:32 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2010-10-13 11:14:22 UTC
Two subclasses of Wocky classes overrode virtual async methods without also overriding the corresponding finish method, which puts them at the mercy of internal changes in Wocky.

This branch is not the minimal fix to make the tests pass: instead, it makes the subclasses not care how Wocky implements those virtual methods. There's quite a bit of boilerplate, but it seems worth having...
Comment 1 Simon McVittie 2010-10-13 11:32:15 UTC
r+ from wjt on IRC, fixed in master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.