Bug 30065 - Port Gabble to undrafted ContactSearch
Summary: Port Gabble to undrafted ContactSearch
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/wj...
Whiteboard: review+ with minor changes
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-09-07 12:00 UTC by Will Thompson
Modified: 2010-09-08 06:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Will Thompson 2010-09-07 12:00:35 UTC 
Hello.

I did this.

I started to port search-channel.c to use Wocky directly for general sanity while I was there, but then I lost the will to live. I might continue later.
Comment 1 Simon McVittie 2010-09-08 03:53:51 UTC 
> +    assertEquals(results.keys(), infos.keys())

I think this assumes they'll fall out of the dict in the same order, which isn't a Python API guarantee. I'd prefer to compare set(results.keys()) with set(infos.keys()) to be sure it'll keep working.

(Four occurrences, including one in unextended.py.)

Other than that, review+
Comment 2 Will Thompson 2010-09-08 06:02:45 UTC 
Merged, ta!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.