Bug 29860 - Use D-Bus API for GNOME screensaver
Summary: Use D-Bus API for GNOME screensaver
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: 1.1.0
Hardware: Other All
: medium normal
Assignee: Fathi Boudra
QA Contact:
Keywords: patch
Depends on:
Reported: 2010-08-28 19:52 UTC by Michael T. Dean
Modified: 2011-04-14 07:16 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Change GNOME screensaver to use D-Bus API (4.25 KB, patch)
2010-08-28 19:52 UTC, Michael T. Dean
Details | Splinter Review

Description Michael T. Dean 2010-08-28 19:52:40 UTC
Created attachment 38253 [details] [review]
Change GNOME screensaver to use D-Bus API

Changes the screensaver_gnome_screensaver to use the GNOME D-Bus API, as documented at http://people.gnome.org/~mccann/gnome-screensaver/docs/gnome-screensaver.html and using the same approach used by the "Use SimulateUserActivity instead of Inhibit for D-Bus screensavers" patch in Bug #26085 and the "Change screensaver_freedesktop's interpretation of GetActive" patch in Bug #29859.

Note, also, that GNOME screensaver's "legacy" inhibit support is currently broken ( https://bugzilla.gnome.org/show_bug.cgi?id=579430 ), and gnome-screensaver-command --poke does not work.  This patch changes xdg-screensaver so it no longer uses gnome-screensaver-command for control, so--in addition to using the "preferred" API for GNOME screensaver control--it also works around the broken legacy inhibit issue.

This patch does not change detectDE or the use of gnome-screensaver-command -q to determine DE.
Comment 1 Rex Dieter 2010-11-18 14:41:17 UTC
Looks like a winner, I'll try to review/test and commit this soon.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.