Currently we cache the TpContact of the TargetHandle of 1-1 text channel so we don't have to recreate it each time we receive a message. We could do a similar optimissation by caching members of group channels so tp-glib would recycle existing TpContact instead of creating new ones.
http://git.collabora.co.uk/?p=user/cassidy/telepathy-logger;a=shortlog;h=refs/heads/members I did some code cleanup while I was on it.
r+, but I have an additional complaint about a pre-existing bug: @@ -224,9 +171,8 @@ pendingproc_get_my_contact (TplActionChain *ctx, TP_CHANNEL (tpl_text)); TpHandle my_handle = tp_connection_get_self_handle (tp_conn); - tpl_text->priv->selector = TP_CONTACT_MYSELF; tp_connection_get_contacts_by_handle (tp_conn, 1, &my_handle, - G_N_ELEMENTS (features), features, got_contact_cb, ctx, NULL, NULL); + G_N_ELEMENTS (features), features, get_self_contact_cb, ctx, NULL, NULL); In a chatroom, shouldn't this be the channel-specific self-handle, if any?
Thanks, I merged the branch. Actually I'm not sure of what the exact semantic is meant to be. KA: any help?
Probably it would make more sense to have a channel-specific self-handle instead. I didn't know the existence of it, this is the only reason TPL was alsways using the connection handle. As long as the is_user attribute in XML (or equivalent) is set to TRUE on local user's messages and to FALSE on any other message, there is no risk of confusion.
Thanks, that was I assumed. I've done that: http://git.collabora.co.uk/?p=user/cassidy/telepathy-logger;a=shortlog;h=refs/heads/members
yes please
Merged.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.